From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.28173.1643291339718938677
 for <devel@edk2.groups.io>;
 Thu, 27 Jan 2022 05:48:59 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CZU026Y9;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1643291338;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=+C84yYjK5N59bmFZCWPj+0hRjH19gl08o2WHjxdjUHw=;
	b=CZU026Y9kdK2DhRaOYPD5IG6F1jktywqyJHfYzfHGQwOfL5VDkHO8EGSfLzxMtd9mVB3qb
	ApEMyKAb+AzdV7fKZc6+ezN6uAsPL6FntqPmxx+66gy7jFLb0jUEPXIP8vlE+O5XSw4H5X
	19tFxypHaXvgd9P+wl8whwgPzm/PH00=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-450-5MWVg0q2NXa6piNMGJkUmg-1; Thu, 27 Jan 2022 08:48:53 -0500
X-MC-Unique: 5MWVg0q2NXa6piNMGJkUmg-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32A4C8519E2;
	Thu, 27 Jan 2022 13:48:52 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.47])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id D61066F94C;
	Thu, 27 Jan 2022 13:48:51 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 27C101800094; Thu, 27 Jan 2022 14:48:50 +0100 (CET)
Date: Thu, 27 Jan 2022 14:48:50 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V2 09/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob
Message-ID: <20220127134850.q5rrxeefqyh3yrru@sirius.home.kraxel.org>
References: <20220125063318.862-1-min.m.xu@intel.com>
 <20220125063318.862-10-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20220125063318.862-10-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +  EFI_HOB_GUID_TYPE      *GuidHob;
> +  EFI_HOB_PLATFORM_INFO  *PlatformInfo = NULL;

>    // Query Host Bridge DID to determine platform type
> +  // Tdx guest stores the HostBridgePciDevId in a GuidHob.
> +  // So we first check if this HOB exists

Hmm, wouldn't it be better to create and use the PlatformInfo for both
PEI-based and PEI-less boot?

> -  HostBridgeDevId = PcdGet16 (PcdOvmfHostBridgePciDevId);
> +  GuidHob = GetFirstGuidHob (&gUefiOvmfPkgTdxPlatformGuid);
> +  if (GuidHob != NULL) {
> +    PlatformInfo    = (EFI_HOB_PLATFORM_INFO *)GET_GUID_HOB_DATA (GuidHob);
> +    HostBridgeDevId = PlatformInfo->HostBridgePciDevId;
> +  } else {
> +    HostBridgeDevId = PcdGet16 (PcdOvmfHostBridgePciDevId);
> +  }

We would not need that kind of checks in the first place then.

take care,
  Gerd