public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg
@ 2022-01-28  9:14 gaoliming
  2022-01-28  9:14 ` [PATCH 1/2] ShellPkg: Add the missing VariablePolicyHelperLib in ShellPkg.dsc gaoliming
  2022-01-28  9:14 ` [PATCH 2/2] NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc gaoliming
  0 siblings, 2 replies; 4+ messages in thread
From: gaoliming @ 2022-01-28  9:14 UTC (permalink / raw)
  To: devel

Commit f4b7b473b4afd0093768905529bfae09a2061d41 adds new library class
dependency in UefiBootManagerLib. The package DSC should add this library 
class instance if it consumes UefiBootManagerLib.

Because this change fixes CI break, it will be merged soon.

Liming Gao (2):
  ShellPkg: Add the missing VariablePolicyHelperLib in ShellPkg.dsc
  NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc

 NetworkPkg/NetworkPkg.dsc | 1 +
 ShellPkg/ShellPkg.dsc     | 1 +
 2 files changed, 2 insertions(+)

-- 
2.27.0.windows.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ShellPkg: Add the missing VariablePolicyHelperLib in ShellPkg.dsc
  2022-01-28  9:14 [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg gaoliming
@ 2022-01-28  9:14 ` gaoliming
  2022-01-28  9:14 ` [PATCH 2/2] NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc gaoliming
  1 sibling, 0 replies; 4+ messages in thread
From: gaoliming @ 2022-01-28  9:14 UTC (permalink / raw)
  To: devel; +Cc: Ray Ni, Zhichao Gao

This change is required by f4b7b473b4afd0093768905529bfae09a2061d41.

Signed-off-by: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
---
 ShellPkg/ShellPkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
index 6f0d092931..38fde3dc71 100644
--- a/ShellPkg/ShellPkg.dsc
+++ b/ShellPkg/ShellPkg.dsc
@@ -43,6 +43,7 @@
   UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
+  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   !include NetworkPkg/NetworkLibs.dsc.inc
 
   ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
-- 
2.27.0.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc
  2022-01-28  9:14 [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg gaoliming
  2022-01-28  9:14 ` [PATCH 1/2] ShellPkg: Add the missing VariablePolicyHelperLib in ShellPkg.dsc gaoliming
@ 2022-01-28  9:14 ` gaoliming
  2022-01-30  0:33   ` [edk2-devel] " Wu, Jiaxin
  1 sibling, 1 reply; 4+ messages in thread
From: gaoliming @ 2022-01-28  9:14 UTC (permalink / raw)
  To: devel; +Cc: Maciej Rabeda, Jiaxin Wu, Siyuan Fu

This change is required by f4b7b473b4afd0093768905529bfae09a2061d41.

Signed-off-by: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
---
 NetworkPkg/NetworkPkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
index 8691a0f5d0..762134023d 100644
--- a/NetworkPkg/NetworkPkg.dsc
+++ b/NetworkPkg/NetworkPkg.dsc
@@ -45,6 +45,7 @@
   DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
   RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
+  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 !ifdef CONTINUOUS_INTEGRATION
   BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
-- 
2.27.0.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH 2/2] NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc
  2022-01-28  9:14 ` [PATCH 2/2] NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc gaoliming
@ 2022-01-30  0:33   ` Wu, Jiaxin
  0 siblings, 0 replies; 4+ messages in thread
From: Wu, Jiaxin @ 2022-01-30  0:33 UTC (permalink / raw)
  To: devel@edk2.groups.io, Gao, Liming; +Cc: Maciej Rabeda, Fu, Siyuan

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Friday, January 28, 2022 5:14 PM
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [edk2-devel] [PATCH 2/2] NetworkPkg: Add the missing
> VariablePolicyHelperLib in NetworkPkg.dsc
> 
> This change is required by f4b7b473b4afd0093768905529bfae09a2061d41.
> 
> Signed-off-by: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> ---
>  NetworkPkg/NetworkPkg.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
> index 8691a0f5d0..762134023d 100644
> --- a/NetworkPkg/NetworkPkg.dsc
> +++ b/NetworkPkg/NetworkPkg.dsc
> @@ -45,6 +45,7 @@
> 
> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl
> eLib.inf
>    SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
>    RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
> +
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va
> riablePolicyHelperLib.inf
> 
>  !ifdef CONTINUOUS_INTEGRATION
>    BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-30  0:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-28  9:14 [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg gaoliming
2022-01-28  9:14 ` [PATCH 1/2] ShellPkg: Add the missing VariablePolicyHelperLib in ShellPkg.dsc gaoliming
2022-01-28  9:14 ` [PATCH 2/2] NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc gaoliming
2022-01-30  0:33   ` [edk2-devel] " Wu, Jiaxin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox