From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase
Date: Fri, 28 Jan 2022 11:20:09 +0100 [thread overview]
Message-ID: <20220128102009.5iwa7vhhpkcsym4b@sirius.home.kraxel.org> (raw)
In-Reply-To: <PH0PR11MB5064E1DE4FC20F523A970684C5229@PH0PR11MB5064.namprd11.prod.outlook.com>
On Fri, Jan 28, 2022 at 08:02:23AM +0000, Xu, Min M wrote:
> On January 27, 2022 9:24 PM, Gerd Hoffmann wrote:
> > On Tue, Jan 25, 2022 at 02:33:10PM +0800, Min Xu wrote:
> > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> > >
> > > Add PcdTdxWorkAreaBase to indicate the area of memory where the TDX
> > > work area block lives.
> >
> > Why have both PcdSevEsWorkAreaBase and PcdTdxWorkAreaBase when we
> > have a shared work area?
> PcdTdxWorkAreaBase mimics PcdSevEsWorkAreaBase. Yes, TdxWorkAreaBase is same as SevEsWorkAreaBase. But the name of TdxWorkAreaBase is more meaningful in the Tdx related code.
Yes, using PcdSevEsWorkAreaBase in TDX code would look somewhat odd, but
we can rename the PCD to have 'CC' in the name like we already did for
other bits shared between sev and tdx.
take care,
Gerd
next prev parent reply other threads:[~2022-01-28 10:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 6:33 [PATCH V2 00/10] Introduce TDVF Config-B (basic) in OvmfPkg Min Xu
2022-01-25 6:33 ` [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Min Xu
2022-01-25 15:09 ` [edk2-devel] " Abner Chang
2022-01-27 0:43 ` Abner Chang
2022-01-27 0:58 ` Min Xu
2022-01-27 1:55 ` Abner Chang
2022-01-27 2:39 ` Min Xu
2022-01-27 3:01 ` Abner Chang
2022-01-27 3:38 ` Min Xu
2022-01-25 6:33 ` [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase Min Xu
2022-01-27 13:24 ` Gerd Hoffmann
2022-01-28 8:02 ` Min Xu
2022-01-28 10:20 ` Gerd Hoffmann [this message]
2022-02-14 1:51 ` Min Xu
2022-02-14 9:58 ` Gerd Hoffmann
2022-01-25 6:33 ` [PATCH V2 03/10] OvmfPkg: Add TdxWorkArea definition Min Xu
2022-01-27 13:25 ` Gerd Hoffmann
2022-01-28 8:01 ` Min Xu
2022-01-28 10:21 ` [edk2-devel] " Gerd Hoffmann
2022-01-25 6:33 ` [PATCH V2 04/10] OvmfPkg: Add PrePiHobListPointerLibTdx Min Xu
2022-01-25 6:33 ` [PATCH V2 05/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings Min Xu
2022-01-27 13:32 ` Gerd Hoffmann
2022-02-14 2:34 ` Min Xu
2022-02-14 10:00 ` Gerd Hoffmann
2022-01-25 6:33 ` [PATCH V2 06/10] OvmfPkg: Add TdxStartupLib Min Xu
2022-01-25 6:33 ` [PATCH V2 07/10] OvmfPkg/IntelTdx: Add Sec to bring up both Legacy and Tdx guest Min Xu
2022-01-27 13:42 ` Gerd Hoffmann
2022-02-08 8:43 ` Min Xu
2022-01-25 6:33 ` [PATCH V2 08/10] OvmfPkg: Update TdxDxe to set TDX PCDs Min Xu
2022-01-25 6:33 ` [PATCH V2 09/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob Min Xu
2022-01-27 13:48 ` Gerd Hoffmann
2022-02-08 8:20 ` Min Xu
2022-02-14 10:03 ` Gerd Hoffmann
2022-02-14 13:09 ` Min Xu
2022-01-25 6:33 ` [PATCH V2 10/10] OvmfPkg: Introduce IntelTdxX64 for TDVF Config-B Min Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128102009.5iwa7vhhpkcsym4b@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox