From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.5595.1643365219391875505 for ; Fri, 28 Jan 2022 02:20:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fkRsJNZ/; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643365218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w4Vf5pY91t+qRJVYLD40+w0v4GiyKw2om0cVlaGrEBw=; b=fkRsJNZ/uSXMprrRlAtx7DeAeHTPPUd6UPBYSsprnON+/qteZ3sfhywWcVb4jIugJQkYvH fp5eUMq7HNKRpcePNQlBD0w+mkRlGwWw/90ScQywh9dcMlbNkr0X7POHOkO34gnLK2LXI+ XqUB6r49Vw0CnIRGMibiuIeAqTKf8k0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-rqQG3n1nNbSdhaOhVM3Flg-1; Fri, 28 Jan 2022 05:20:13 -0500 X-MC-Unique: rqQG3n1nNbSdhaOhVM3Flg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76D31814243; Fri, 28 Jan 2022 10:20:11 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FFCC752C7; Fri, 28 Jan 2022 10:20:11 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6B4D21800608; Fri, 28 Jan 2022 11:20:09 +0100 (CET) Date: Fri, 28 Jan 2022 11:20:09 +0100 From: "Gerd Hoffmann" To: "Xu, Min M" Cc: "devel@edk2.groups.io" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Ni, Ray" Subject: Re: [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase Message-ID: <20220128102009.5iwa7vhhpkcsym4b@sirius.home.kraxel.org> References: <20220125063318.862-1-min.m.xu@intel.com> <20220125063318.862-3-min.m.xu@intel.com> <20220127132412.oqizta4k7mbtclpb@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 28, 2022 at 08:02:23AM +0000, Xu, Min M wrote: > On January 27, 2022 9:24 PM, Gerd Hoffmann wrote: > > On Tue, Jan 25, 2022 at 02:33:10PM +0800, Min Xu wrote: > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > > > Add PcdTdxWorkAreaBase to indicate the area of memory where the TDX > > > work area block lives. > > > > Why have both PcdSevEsWorkAreaBase and PcdTdxWorkAreaBase when we > > have a shared work area? > PcdTdxWorkAreaBase mimics PcdSevEsWorkAreaBase. Yes, TdxWorkAreaBase is same as SevEsWorkAreaBase. But the name of TdxWorkAreaBase is more meaningful in the Tdx related code. Yes, using PcdSevEsWorkAreaBase in TDX code would look somewhat odd, but we can rename the PCD to have 'CC' in the name like we already did for other bits shared between sev and tdx. take care, Gerd