From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web12.5475.1643365297627119820
 for <devel@edk2.groups.io>;
 Fri, 28 Jan 2022 02:21:38 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=d3jfR+Iz;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1643365296;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UWyG26caDQAwsgnQLM83JxasWDPScL4kPaGQVxsHKVM=;
	b=d3jfR+IzmBa+nGWGuEFaVXv56gG/nX2/C5lILn+QFq3J3XUvsYVVnXZU2qVr6YXwjLphzG
	+GqtxMIBL1YrbtVXGn4GhEjpsbQJqorbTsKWY7hKMAlU8KGL7LQ4SvnIw/Kae46eSU7KYS
	xPu62B8umPQopcynxlCyWPR6zjtxNwg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-427-XW3Npo_gPEG1kkbARo-MlQ-1; Fri, 28 Jan 2022 05:21:33 -0500
X-MC-Unique: XW3Npo_gPEG1kkbARo-MlQ-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0793383DEA9;
	Fri, 28 Jan 2022 10:21:32 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.47])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id BA041104FF;
	Fri, 28 Jan 2022 10:21:31 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 12F361800608; Fri, 28 Jan 2022 11:21:30 +0100 (CET)
Date: Fri, 28 Jan 2022 11:21:30 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, min.m.xu@intel.com
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V2 03/10] OvmfPkg: Add TdxWorkArea definition
Message-ID: <20220128102130.vb7sihyvv4gsvgv4@sirius.home.kraxel.org>
References: <20220125063318.862-1-min.m.xu@intel.com>
 <20220125063318.862-4-min.m.xu@intel.com>
 <20220127132552.trn5bwlouxhoda3y@sirius.home.kraxel.org>
 <PH0PR11MB50646A04F687E2BFC529FECBC5229@PH0PR11MB5064.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB50646A04F687E2BFC529FECBC5229@PH0PR11MB5064.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > > +typedef struct _TDX_WORK_AREA {
> > > +  CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER    Header;
> > > +  SEC_TDX_WORK_AREA                          SecTdxWorkArea;
> > > +} TDX_WORK_AREA;
> > > +
> > >  typedef union {
> > >    CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER    Header;
> > >    SEV_WORK_AREA                              SevWorkArea;
> > > +  TDX_WORK_AREA                              TdxWorkArea;
> > >  } OVMF_WORK_AREA;
> > 
> > Now you have the CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER
> > twice ...
> OVMF_WORK_AREA is an union. TDX_WORK_AREA is a struct. So there is one CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER.

Ah, right.  Scratch the comment then.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd