From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web12.5620.1643366474622642263 for ; Fri, 28 Jan 2022 02:41:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D8FqKegA; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643366473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m8hVYP2K7w/z9dXlestFIQljMkbWURkFMt5S4DzxBIM=; b=D8FqKegAfeFIWX15/IzcPeej2cA6VCiFw7FMNTNDR9vucrzm00D71DuM/UMmGSja1p5VFu sJSu0QjlaJWBaVk1KiGtJZs9WqvijN63J/9aosdBi7qqsK2YMTngEOlvMv67MMdjBUFjAj RnxQoanhuw6jXMhBfzroeGFRFgNcpxE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-622-1TrgWQC9Or6IrQKBzihDBw-1; Fri, 28 Jan 2022 05:41:10 -0500 X-MC-Unique: 1TrgWQC9Or6IrQKBzihDBw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 470661083F62; Fri, 28 Jan 2022 10:41:09 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0CED0752B2; Fri, 28 Jan 2022 10:41:09 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4F8B91800608; Fri, 28 Jan 2022 11:41:07 +0100 (CET) Date: Fri, 28 Jan 2022 11:41:07 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, ncoleon@amazon.com Cc: atugup@amazon.com, Alexander Graf Subject: Re: [edk2-devel] [PATCH v3 5/8] OvmfPkg/PciHostBridgeUtilityLib: Initialize RootBridges apertures with spec Message-ID: <20220128104107.w5rrxjmce7yp26pp@sirius.home.kraxel.org> References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > @@ -234,14 +237,29 @@ PciHostBridgeUtilityGetRootBridges ( The patch turns PciHostBridgeUtilityGetRootBridges into a rather large function, I think it makes sense to split it, i.e. rename the existing function into something like PciHostBridgeUtilityGetRootBridgesBusScan, add the new code to PciHostBridgeUtilityGetRootBridgesHostProvided, then PciHostBridgeUtilityGetRootBridges being a thin wrapper calling the other two? take care, Gerd