From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.5545.1643367170098198446 for ; Fri, 28 Jan 2022 02:52:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ahqFYX3F; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643367169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxiYPYb2BY/3tu1e0Qibqkb0jdhLSePGdRMGRWZLOCA=; b=ahqFYX3FtCVN9UWWfiJ7Hp81v/za4Fqn0Sid8SKWONw7A31itdcQmSoScGCNCcV6BssH7c 423UMnUbGkAACSQ9mWfJBgVSHxRa6uY3cv19knC+/O1Ed28i6JLnEWxkRMNqMViiLg8OB2 Q/BKJ6jMbwJZy+1jIwp82qaVHPa+KuE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-erFsTZ1hMTG4a_-85tzmmw-1; Fri, 28 Jan 2022 05:52:44 -0500 X-MC-Unique: erFsTZ1hMTG4a_-85tzmmw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0250518B9EA1; Fri, 28 Jan 2022 10:52:43 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1671466E15; Fri, 28 Jan 2022 10:52:42 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 510241800608; Fri, 28 Jan 2022 11:52:40 +0100 (CET) Date: Fri, 28 Jan 2022 11:52:40 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, ncoleon@amazon.com Cc: atugup@amazon.com, Alexander Graf Subject: Re: [edk2-devel] [PATCH v3 7/8] MdeModulePkg/Pci MdePkg: Create service to retrieve PCI base addresses Message-ID: <20220128105240.2uofqayzqo5mfbto@sirius.home.kraxel.org> References: <9447e1ddbb2aa9089456a25779cd5b8e1f0140ac.1643120206.git.ncoleon@amazon.com> MIME-Version: 1.0 In-Reply-To: <9447e1ddbb2aa9089456a25779cd5b8e1f0140ac.1643120206.git.ncoleon@amazon.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > --- a/MdePkg/Include/Protocol/PciHostBridgeResourceAllocation.h > +++ b/MdePkg/Include/Protocol/PciHostBridgeResourceAllocation.h > @@ -367,6 +367,33 @@ EFI_STATUS > IN EFI_PCI_CONTROLLER_RESOURCE_ALLOCATION_PHASE Phase > ); > > +/** > + Retrieves the base addresses of ost bridge resources. > + > + @param This The pointer to the EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL instance. > + @param RootBridgeHandle The PCI root bridge handle. > + @param IoBase The pointer to PIO aperture base address. > + @param Mem32Base The pointer to 32-bit aperture base address. > + @param PMem32Base The pointer to 32-bit prefetchable aperture base address. > + @param Mem64Base The pointer to 64-bit aperture base address. > + @param PMem64Base The pointer to 64-bit prefetchable aperture base address. > + > + @retval EFI_SUCCESS Succeed. > + @retval EFI_NOT_FOUND Root bridge was not found. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL_GET_RESOURCES_BASES)( > + IN EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL *This, > + IN EFI_HANDLE RootBridgeHandle, > + OUT UINT64 *IoBase, > + OUT UINT64 *Mem32Base, > + OUT UINT64 *PMem32Base, > + OUT UINT64 *Mem64Base, > + OUT UINT64 *PMem64Base > + ); > + > /// > /// Provides the basic interfaces to abstract a PCI host bridge resource allocation. > /// > @@ -415,6 +442,12 @@ struct _EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL { > /// before enumeration. > /// > EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL_PREPROCESS_CONTROLLER PreprocessController; > + > + /// > + /// Returns the aligned base addresses of the different resource windows > + /// of the host bridge. Intended for use before resources are submitted. > + /// > + EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL_GET_RESOURCES_BASES GetResourcesBases; > }; Hmm, not sure the protocol can be changed like that without risking breakage, the uefi protocols are the binary interface between uefi modules ... take care, Gerd