From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web08.46108.1643708404534033802
 for <devel@edk2.groups.io>;
 Tue, 01 Feb 2022 01:40:05 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AEReL6Cw;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1643708403;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=KMM3Alxa+Eyz4k25ne/sO0s1QuVvJS5cgryAaKIyXa0=;
	b=AEReL6CwbReJ4X7onsebqILkV4GnOFSgyZhYF0/xUiPwHA/NKmptK2iMo4BwhDItrH4NXd
	sb4UHqgJvP+Tc7aU/H4INbavvQGSmGK7RKfZnwQUpi664KTI9ii2KkQXO8WLoh0X6edIQ7
	ObUsLy/ErcEfGNK/eOHHcRUyoIdPDSU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-492-OPrVWxQDNIKO2tLZFUSG4Q-1; Tue, 01 Feb 2022 04:39:56 -0500
X-MC-Unique: OPrVWxQDNIKO2tLZFUSG4Q-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8E61784BA42;
	Tue,  1 Feb 2022 09:39:55 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.47])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 558F71F469;
	Tue,  1 Feb 2022 09:39:55 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 6F91D1800632; Tue,  1 Feb 2022 10:39:53 +0100 (CET)
Date: Tue, 1 Feb 2022 10:39:53 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH 00/24] CryptoPkg/openssl: update openssl submodule to v3.0
Message-ID: <20220201093953.upbjfarkuk6t6gvu@sirius.home.kraxel.org>
References: <20220128140723.isljt6lz6the7k5y@sirius.home.kraxel.org>
 <CAKbZUD1CUDS11eE=7T2aHit28OE7uXQwt9qz1Oo5fd3t0c=dOg@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAKbZUD1CUDS11eE=7T2aHit28OE7uXQwt9qz1Oo5fd3t0c=dOg@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 28, 2022 at 03:54:00PM +0000, Pedro Falcato wrote:
> Gerd,
> 
> As I mentioned earlier, abort() is one of 5 functions GCC expects in
> freestanding mode (plus memset, mempy and two others).
> 
> Is there any floating point enabled somewhere? I really don't remember
> having seen those undefined references to fprintf, ever.

That is one of the things I havn't figured yet ...

libgcc is basically a collection of object files, and the linker should
cherry-pick those which it needs (for example add the _divdi3.o object
to resolve the __divdi3 symbol) and ignore everything else.

The "ignore everything else" part seems to not work though:

> > /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_absvsi2.o): in
> > function `__absvdi2':
> > (.text+0x18): undefined reference to `abort'

Nothing in edk2 needs __absvdi2.  Nevertheless the linker looks at
_absvsi2.o and tries to resolve the symbols used.

Unpacking libgcc, cherry-picking the object files actually needed, then
packing the picked object files into a library and use that works.  But
IMHO that is something the linker should be able to figure on its own.

take care,
  Gerd