* [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout @ 2022-02-01 18:03 Ard Biesheuvel 2022-02-02 9:42 ` PierreGondois 0 siblings, 1 reply; 4+ messages in thread From: Ard Biesheuvel @ 2022-02-01 18:03 UTC (permalink / raw) To: devel; +Cc: pierre.gondois, leif, Ard Biesheuvel Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up to the Timeout EFI variable automatically, which is how the boot manager stores the timeout preference. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> --- ArmVirtPkg/ArmVirtKvmTool.dsc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc index a1bf4b9be87b..3bd3ebd6e0b3 100644 --- a/ArmVirtPkg/ArmVirtKvmTool.dsc +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc @@ -170,9 +170,10 @@ [PcdsPatchableInModule.common] gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x0 +[PcdsDynamicHii] + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalVariableGuid|0x0|5 + [PcdsDynamicDefault.common] - gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 - gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0 gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0 gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0 -- 2.30.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout 2022-02-01 18:03 [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout Ard Biesheuvel @ 2022-02-02 9:42 ` PierreGondois 2022-02-02 10:03 ` [edk2-devel] " Sami Mujawar 0 siblings, 1 reply; 4+ messages in thread From: PierreGondois @ 2022-02-02 9:42 UTC (permalink / raw) To: Ard Biesheuvel, devel; +Cc: leif Hi, The value also gets updated from 3 to 5, is it possible to note it in the commit message or to let it to 3 ? Otherwise the patch looks good to me, Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> On 2/1/22 7:03 PM, Ard Biesheuvel wrote: > Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up > to the Timeout EFI variable automatically, which is how the boot manager > stores the timeout preference. > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > --- > ArmVirtPkg/ArmVirtKvmTool.dsc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc > index a1bf4b9be87b..3bd3ebd6e0b3 100644 > --- a/ArmVirtPkg/ArmVirtKvmTool.dsc > +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc > @@ -170,9 +170,10 @@ [PcdsPatchableInModule.common] > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x0 > > +[PcdsDynamicHii] > + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalVariableGuid|0x0|5 > + > [PcdsDynamicDefault.common] > - gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 > - > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0 > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0 > gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout 2022-02-02 9:42 ` PierreGondois @ 2022-02-02 10:03 ` Sami Mujawar 2022-02-25 16:48 ` Ard Biesheuvel 0 siblings, 1 reply; 4+ messages in thread From: Sami Mujawar @ 2022-02-02 10:03 UTC (permalink / raw) To: devel@edk2.groups.io, Pierre Gondois, Ard Biesheuvel; +Cc: leif@nuviainc.com Hi Ard, Thank you for this patch. The timeout value 5 appears to be standard across platforms, so it looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> Regards, Sami Mujawar On 02/02/2022, 09:42, "devel@edk2.groups.io on behalf of PierreGondois via groups.io" <devel@edk2.groups.io on behalf of pierre.gondois=arm.com@groups.io> wrote: Hi, The value also gets updated from 3 to 5, is it possible to note it in the commit message or to let it to 3 ? Otherwise the patch looks good to me, Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> On 2/1/22 7:03 PM, Ard Biesheuvel wrote: > Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up > to the Timeout EFI variable automatically, which is how the boot manager > stores the timeout preference. > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > --- > ArmVirtPkg/ArmVirtKvmTool.dsc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc > index a1bf4b9be87b..3bd3ebd6e0b3 100644 > --- a/ArmVirtPkg/ArmVirtKvmTool.dsc > +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc > @@ -170,9 +170,10 @@ [PcdsPatchableInModule.common] > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x0 > > +[PcdsDynamicHii] > + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalVariableGuid|0x0|5 > + > [PcdsDynamicDefault.common] > - gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 > - > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0 > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0 > gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0 > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout 2022-02-02 10:03 ` [edk2-devel] " Sami Mujawar @ 2022-02-25 16:48 ` Ard Biesheuvel 0 siblings, 0 replies; 4+ messages in thread From: Ard Biesheuvel @ 2022-02-25 16:48 UTC (permalink / raw) To: edk2-devel-groups-io, Sami Mujawar; +Cc: Pierre Gondois, leif@nuviainc.com On Wed, 2 Feb 2022 at 11:04, Sami Mujawar <sami.mujawar@arm.com> wrote: > > Hi Ard, > > Thank you for this patch. > > The timeout value 5 appears to be standard across platforms, so it looks good to me. > > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> > > Regards, > > Sami Mujawar > Merged as #2547 (with a mention of the change to 5 seconds in the commit log) Thanks all, > On 02/02/2022, 09:42, "devel@edk2.groups.io on behalf of PierreGondois via groups.io" <devel@edk2.groups.io on behalf of pierre.gondois=arm.com@groups.io> wrote: > > Hi, > The value also gets updated from 3 to 5, is it possible to note it in the > commit message or to let it to 3 ? > Otherwise the patch looks good to me, > > Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> > > > On 2/1/22 7:03 PM, Ard Biesheuvel wrote: > > Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up > > to the Timeout EFI variable automatically, which is how the boot manager > > stores the timeout preference. > > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > > --- > > ArmVirtPkg/ArmVirtKvmTool.dsc | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc > > index a1bf4b9be87b..3bd3ebd6e0b3 100644 > > --- a/ArmVirtPkg/ArmVirtKvmTool.dsc > > +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc > > @@ -170,9 +170,10 @@ [PcdsPatchableInModule.common] > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x0 > > > > +[PcdsDynamicHii] > > + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalVariableGuid|0x0|5 > > + > > [PcdsDynamicDefault.common] > > - gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 > > - > > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0 > > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0 > > gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0 > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-25 16:48 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-02-01 18:03 [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout Ard Biesheuvel 2022-02-02 9:42 ` PierreGondois 2022-02-02 10:03 ` [edk2-devel] " Sami Mujawar 2022-02-25 16:48 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox