From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.18991.1644360760334944517 for ; Tue, 08 Feb 2022 14:52:40 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YYowLWCz; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: guo.dong@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644360760; x=1675896760; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=xjQpDWLkbM4a9gYd5GedjexLLba9l0yF1WTb7UwHVKE=; b=YYowLWCz38TlEHp1boKEl2T5vFndRh1Tky+sMwO/qlphhofLlDwSZ76B HLzWLQoiGQ04F8cTVdBXhQmtPZgNEpFiS7ROksEYwFyx83uWnVAzEmzhG j++yVX3CD+ZQSq15OQqU4v5/Ipw+O7XTZRFYkDRfBvcghT93QTA+pVJGK PTYq/dHAiAAsdGW37Pml/nB11gmiiFx69tm6E+lOPyNa5qJxJ+2AW4XmQ nmcBP1f+ey7zn4iMAI2nvH25FioG7USmL93DMlOJJ38PY+o7E1mN8rstS LZ5j81A+zWouWLVgK9Z9jUYX8DBM5c8ethyBqz8dgfVMZJ+DKuxmP/ldL w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="335471981" X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="335471981" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 14:52:31 -0800 X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="633010884" Received: from gdong1-mobl1.amr.corp.intel.com ([10.213.162.217]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 14:52:30 -0800 From: "Guo Dong" To: devel@edk2.groups.io Cc: Guo Dong , Ray Ni , Maurice Ma , Benjamin You Subject: [`edk2-devel][PATCH] UefiPayloadPkg: Fix build error Date: Tue, 8 Feb 2022 15:51:55 -0700 Message-Id: <20220208225155.189-1-guo.dong@intel.com> X-Mailer: git-send-email 2.35.1.windows.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Guo Dong On windows build, need add "-DPLATFORMX64_ENABLE=3DTRUE" in the build command line beside -DNETWORK_DRIVER_ENABLE=3DTRUE in order build network features. So update DSC to set PLATFORMX64_ENABLE to TRUE when building network feature. On Linux build, DSC file should not have PcdAllowHttpConnections without building network feature, else it would cause build error. Signed-off-by: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc index 1ce96a51c1..fd5739499a 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -402,7 +402,9 @@ [PcdsPatchableInModule.X64]=0D gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)= =0D gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER= )=0D +!if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE=0D gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE=0D +!endif=0D =0D [PcdsPatchableInModule.common]=0D gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c= , 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0= x31 }=0D @@ -525,6 +527,8 @@ # UEFI network modules=0D #=0D !if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE=0D +[Defines]=0D + DEFINE PLATFORMX64_ENABLE =3D TRUE=0D !include NetworkPkg/Network.dsc.inc=0D !endif=0D =0D --=20 2.26.2.windows.1