* [`edk2-devel][PATCH] UefiPayloadPkg: Fix build error
@ 2022-02-08 22:51 Guo Dong
0 siblings, 0 replies; 6+ messages in thread
From: Guo Dong @ 2022-02-08 22:51 UTC (permalink / raw)
To: devel; +Cc: Guo Dong, Ray Ni, Maurice Ma, Benjamin You
From: Guo Dong <guo.dong@intel.com>
On windows build, need add "-DPLATFORMX64_ENABLE=TRUE" in the build
command line beside -DNETWORK_DRIVER_ENABLE=TRUE in order build
network features. So update DSC to set PLATFORMX64_ENABLE to TRUE
when building network feature.
On Linux build, DSC file should not have PcdAllowHttpConnections
without building network feature, else it would cause build error.
Signed-off-by: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 1ce96a51c1..fd5739499a 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -402,7 +402,9 @@
[PcdsPatchableInModule.X64]
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER)
+!if $(NETWORK_DRIVER_ENABLE) == TRUE
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
+!endif
[PcdsPatchableInModule.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
@@ -525,6 +527,8 @@
# UEFI network modules
#
!if $(NETWORK_DRIVER_ENABLE) == TRUE
+[Defines]
+ DEFINE PLATFORMX64_ENABLE = TRUE
!include NetworkPkg/Network.dsc.inc
!endif
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] UefiPayloadPkg: Fix build error
@ 2022-03-11 13:41 Sean Rhodes
2022-03-14 3:12 ` [edk2-devel] " Ni, Ray
2022-03-23 19:46 ` Sean Rhodes
0 siblings, 2 replies; 6+ messages in thread
From: Sean Rhodes @ 2022-03-11 13:41 UTC (permalink / raw)
To: devel; +Cc: Guo Dong, Ray Ni, Maurice Ma, Benjamin You
From: Guo Dong <guo.dong@intel.com>
On windows build, need add -DPLATFORMX64_ENABLE=TRUE in the build
command line beside -DNETWORK_DRIVER_ENABLE=TRUE in order build
network features. So set PLATFORMX64_ENABLE to TRUE when need build
network feature.
On Linux build, DSC file should not have PcdAllowHttpConnections
when network feature is not built, else would cause build error.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 558513baf1..f3806a8ebc 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -407,7 +407,9 @@
[PcdsPatchableInModule.X64]
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER)
+!if $(NETWORK_DRIVER_ENABLE) == TRUE
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
+!endif
[PcdsPatchableInModule.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
@@ -530,6 +532,8 @@
# UEFI network modules
#
!if $(NETWORK_DRIVER_ENABLE) == TRUE
+[Defines]
+ DEFINE PLATFORMX64_ENABLE = TRUE
!include NetworkPkg/Network.dsc.inc
!endif
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
2022-03-11 13:41 [PATCH] " Sean Rhodes
@ 2022-03-14 3:12 ` Ni, Ray
2022-03-14 16:31 ` Guo Dong
2022-03-23 19:46 ` Sean Rhodes
1 sibling, 1 reply; 6+ messages in thread
From: Ni, Ray @ 2022-03-14 3:12 UTC (permalink / raw)
To: devel@edk2.groups.io, Rhodes, Sean; +Cc: Dong, Guo, Ma, Maurice, You, Benjamin
I don't understand the need of "+ DEFINE PLATFORMX64_ENABLE = TRUE".
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Friday, March 11, 2022 9:41 PM
To: devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
From: Guo Dong <guo.dong@intel.com>
On windows build, need add -DPLATFORMX64_ENABLE=TRUE in the build
command line beside -DNETWORK_DRIVER_ENABLE=TRUE in order build
network features. So set PLATFORMX64_ENABLE to TRUE when need build
network feature.
On Linux build, DSC file should not have PcdAllowHttpConnections
when network feature is not built, else would cause build error.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 558513baf1..f3806a8ebc 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -407,7 +407,9 @@
[PcdsPatchableInModule.X64]
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER)
+!if $(NETWORK_DRIVER_ENABLE) == TRUE
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
+!endif
[PcdsPatchableInModule.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
@@ -530,6 +532,8 @@
# UEFI network modules
#
!if $(NETWORK_DRIVER_ENABLE) == TRUE
+[Defines]
+ DEFINE PLATFORMX64_ENABLE = TRUE
!include NetworkPkg/Network.dsc.inc
!endif
--
2.32.0
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87463): https://edk2.groups.io/g/devel/message/87463
Mute This Topic: https://groups.io/mt/89710183/1712937
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
-=-=-=-=-=-=
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
2022-03-14 3:12 ` [edk2-devel] " Ni, Ray
@ 2022-03-14 16:31 ` Guo Dong
2022-03-21 8:51 ` Sean Rhodes
0 siblings, 1 reply; 6+ messages in thread
From: Guo Dong @ 2022-03-14 16:31 UTC (permalink / raw)
To: Ni, Ray, devel@edk2.groups.io, Rhodes, Sean; +Cc: Ma, Maurice, You, Benjamin
You would understand it when you look at the NetworkPkg/Network.dsc.inc
In that DSC file, network components could be built as X64 or IA32 depending on PLATFORMX64_ENABLE.
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Sunday, March 13, 2022 8:13 PM
To: devel@edk2.groups.io; Rhodes, Sean <sean@starlabs.systems>
Cc: Dong, Guo <guo.dong@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
I don't understand the need of "+ DEFINE PLATFORMX64_ENABLE = TRUE".
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Friday, March 11, 2022 9:41 PM
To: devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
From: Guo Dong <guo.dong@intel.com>
On windows build, need add -DPLATFORMX64_ENABLE=TRUE in the build command line beside -DNETWORK_DRIVER_ENABLE=TRUE in order build network features. So set PLATFORMX64_ENABLE to TRUE when need build network feature.
On Linux build, DSC file should not have PcdAllowHttpConnections when network feature is not built, else would cause build error.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 558513baf1..f3806a8ebc 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -407,7 +407,9 @@
[PcdsPatchableInModule.X64]
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER)
+!if $(NETWORK_DRIVER_ENABLE) == TRUE
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
+!endif
[PcdsPatchableInModule.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
@@ -530,6 +532,8 @@
# UEFI network modules
#
!if $(NETWORK_DRIVER_ENABLE) == TRUE
+[Defines]
+ DEFINE PLATFORMX64_ENABLE = TRUE
!include NetworkPkg/Network.dsc.inc
!endif
--
2.32.0
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87463): https://edk2.groups.io/g/devel/message/87463
Mute This Topic: https://groups.io/mt/89710183/1712937
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
-=-=-=-=-=-=
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
2022-03-14 16:31 ` Guo Dong
@ 2022-03-21 8:51 ` Sean Rhodes
2022-03-23 17:57 ` Guo Dong
0 siblings, 1 reply; 6+ messages in thread
From: Sean Rhodes @ 2022-03-21 8:51 UTC (permalink / raw)
To: Guo Dong, devel
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
The patch looks good to me, and it has been confirmed by several others from the coreboot community. However, I don't have the capability to merge.
Thanks
Sean
[-- Attachment #2: Type: text/html, Size: 171 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
2022-03-21 8:51 ` Sean Rhodes
@ 2022-03-23 17:57 ` Guo Dong
0 siblings, 0 replies; 6+ messages in thread
From: Guo Dong @ 2022-03-23 17:57 UTC (permalink / raw)
To: Rhodes, Sean, devel@edk2.groups.io
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
As a package reviewer, you just need review it and reply it with “Reviewed-by” then the maintainer would merge it.
Thanks,
Guo
From: Sean Rhodes <sean@starlabs.systems>
Sent: Monday, March 21, 2022 1:52 AM
To: Dong, Guo <guo.dong@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
The patch looks good to me, and it has been confirmed by several others from the coreboot community. However, I don't have the capability to merge.
Thanks
Sean
[-- Attachment #2: Type: text/html, Size: 2905 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
2022-03-11 13:41 [PATCH] " Sean Rhodes
2022-03-14 3:12 ` [edk2-devel] " Ni, Ray
@ 2022-03-23 19:46 ` Sean Rhodes
1 sibling, 0 replies; 6+ messages in thread
From: Sean Rhodes @ 2022-03-23 19:46 UTC (permalink / raw)
To: Sean Rhodes, devel
[-- Attachment #1: Type: text/plain, Size: 49 bytes --]
Reviewed-by Sean Rhodes <sean@starlabs.systems>
[-- Attachment #2: Type: text/html, Size: 55 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-23 19:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-08 22:51 [`edk2-devel][PATCH] UefiPayloadPkg: Fix build error Guo Dong
-- strict thread matches above, loose matches on Subject: below --
2022-03-11 13:41 [PATCH] " Sean Rhodes
2022-03-14 3:12 ` [edk2-devel] " Ni, Ray
2022-03-14 16:31 ` Guo Dong
2022-03-21 8:51 ` Sean Rhodes
2022-03-23 17:57 ` Guo Dong
2022-03-23 19:46 ` Sean Rhodes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox