From: "Ming Huang" <huangming@linux.alibaba.com>
To: devel@edk2.groups.io, sami.mujawar@arm.com,
ardb+tianocore@kernel.org, jiewen.yao@intel.com,
supreeth.venkatesh@arm.com
Cc: ming.huang-@outlook.com, Ming Huang <huangming@linux.alibaba.com>
Subject: [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue
Date: Wed, 9 Feb 2022 20:25:58 +0800 [thread overview]
Message-ID: <20220209122558.60329-3-huangming@linux.alibaba.com> (raw)
In-Reply-To: <20220209122558.60329-1-huangming@linux.alibaba.com>
The heap space will be rewrote if a StandloneMmPkg module create HOB
by BuildGuidHob() interface and write data to HOB space.
Add a PCD PcdMemoryHobSize for pre-allocation a space to create HOB to
fix this issue.
Signed-off-by: Ming Huang <huangming@linux.alibaba.com>
---
StandaloneMmPkg/Core/StandaloneMmCore.c | 17 ++++++++++++++++-
StandaloneMmPkg/Core/StandaloneMmCore.inf | 3 +++
StandaloneMmPkg/StandaloneMmPkg.dec | 2 ++
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c b/StandaloneMmPkg/Core/StandaloneMmCore.c
index d221f1d111..1cf259d946 100644
--- a/StandaloneMmPkg/Core/StandaloneMmCore.c
+++ b/StandaloneMmPkg/Core/StandaloneMmCore.c
@@ -512,6 +512,9 @@ StandaloneMmMain (
EFI_MMRAM_DESCRIPTOR *MmramRanges;
UINTN MmramRangeCount;
EFI_HOB_FIRMWARE_VOLUME *BfvHob;
+ EFI_HOB_HANDOFF_INFO_TABLE *HandOffHobNew;
+ EFI_HOB_HANDOFF_INFO_TABLE *HandOffHobOrg;
+ UINT64 MaxHobSize = PcdGet64 (PcdMemoryHobSize);
ProcessLibraryConstructorList (HobStart, &gMmCoreMmst);
@@ -619,10 +622,22 @@ StandaloneMmMain (
//
HobSize = GetHobListSize (HobStart);
DEBUG ((DEBUG_INFO, "HobSize - 0x%x\n", HobSize));
- MmHobStart = AllocatePool (HobSize);
+ ASSERT (HobSize <= MaxHobSize);
+ MmHobStart = AllocatePool (MaxHobSize);
DEBUG ((DEBUG_INFO, "MmHobStart - 0x%x\n", MmHobStart));
ASSERT (MmHobStart != NULL);
CopyMem (MmHobStart, HobStart, HobSize);
+ //
+ // Initlialize the new HOB table
+ //
+ HandOffHobOrg = (EFI_HOB_HANDOFF_INFO_TABLE *)HobStart;
+ HandOffHobNew = (EFI_HOB_HANDOFF_INFO_TABLE *)MmHobStart;
+ HandOffHobNew->EfiEndOfHobList = (EFI_PHYSICAL_ADDRESS)MmHobStart +
+ (HandOffHobOrg->EfiEndOfHobList - (EFI_PHYSICAL_ADDRESS)HobStart);
+ HandOffHobNew->EfiFreeMemoryBottom = HandOffHobNew->EfiEndOfHobList +
+ sizeof (EFI_HOB_GENERIC_HEADER);
+ HandOffHobNew->EfiFreeMemoryTop = (EFI_PHYSICAL_ADDRESS)MmHobStart + MaxHobSize;
+
Status = MmInstallConfigurationTable (&gMmCoreMmst, &gEfiHobListGuid, MmHobStart, HobSize);
ASSERT_EFI_ERROR (Status);
diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.inf b/StandaloneMmPkg/Core/StandaloneMmCore.inf
index c44b9ff333..37e6135d73 100644
--- a/StandaloneMmPkg/Core/StandaloneMmCore.inf
+++ b/StandaloneMmPkg/Core/StandaloneMmCore.inf
@@ -76,6 +76,9 @@
gEfiEventExitBootServicesGuid
gEfiEventReadyToBootGuid
+[FixedPcd]
+ gStandaloneMmPkgTokenSpaceGuid.PcdMemoryHobSize
+
#
# This configuration fails for CLANGPDB, which does not support PIE in the GCC
# sense. Such however is required for ARM family StandaloneMmCore
diff --git a/StandaloneMmPkg/StandaloneMmPkg.dec b/StandaloneMmPkg/StandaloneMmPkg.dec
index 46784d94e4..cf554676e2 100644
--- a/StandaloneMmPkg/StandaloneMmPkg.dec
+++ b/StandaloneMmPkg/StandaloneMmPkg.dec
@@ -48,3 +48,5 @@
gEfiStandaloneMmNonSecureBufferGuid = { 0xf00497e3, 0xbfa2, 0x41a1, { 0x9d, 0x29, 0x54, 0xc2, 0xe9, 0x37, 0x21, 0xc5 }}
gEfiArmTfCpuDriverEpDescriptorGuid = { 0x6ecbd5a1, 0xc0f8, 0x4702, { 0x83, 0x01, 0x4f, 0xc2, 0xc5, 0x47, 0x0a, 0x51 }}
+[PcdsFixedAtBuild]
+ gStandaloneMmPkgTokenSpaceGuid.PcdMemoryHobSize|0x00000000|UINT64|0x00000004
--
2.17.1
next prev parent reply other threads:[~2022-02-09 12:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 12:25 [PATCH v1 0/2] Fix StandaloneMmPkg HOB issue Ming Huang
2022-02-09 12:25 ` [PATCH v1 1/2] StandaloneMmPkg/Hob: Assert or return NULL for create hob failed Ming Huang
2022-02-09 12:25 ` Ming Huang [this message]
2022-05-03 9:10 ` [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue Ard Biesheuvel
2022-05-12 10:09 ` [edk2-devel] " Ming Huang
2023-08-16 8:55 ` Nhi Pham via groups.io
2023-08-30 13:10 ` Ard Biesheuvel
2023-08-31 8:20 ` Nhi Pham via groups.io
2023-09-01 20:43 ` Oliver Smith-Denny
2023-09-05 2:20 ` Nhi Pham via groups.io
2023-09-05 21:29 ` Oliver Smith-Denny
2023-09-06 6:33 ` Ni, Ray
2023-09-06 6:56 ` Ard Biesheuvel
2023-09-06 7:55 ` Nhi Pham via groups.io
2023-09-06 8:50 ` Ard Biesheuvel
2023-09-06 16:22 ` Oliver Smith-Denny
2023-09-07 15:38 ` Nhi Pham via groups.io
2023-11-30 13:59 ` Nhi Pham via groups.io
2023-12-01 5:29 ` Ni, Ray
2023-09-06 7:35 ` Nhi Pham via groups.io
[not found] ` <177BD141FD103BE4.8497@groups.io>
2023-08-29 2:48 ` Nhi Pham via groups.io
2022-03-30 9:35 ` [PATCH v1 0/2] Fix StandaloneMmPkg HOB issue Ming Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209122558.60329-3-huangming@linux.alibaba.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox