From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web09.32209.1644832739143230627
 for <devel@edk2.groups.io>;
 Mon, 14 Feb 2022 01:58:59 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YdZuRTc5;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1644832738;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZlTM5I9pOFKeLFF/hGsas4yUR1cuqMkPQOJw9QQx1G0=;
	b=YdZuRTc5ocotaphjJqqFYJhUn7saDYGnI6i/k7Ilh9kJN4gOrpLEkhOxpCO5e6ivhzFdFR
	kiNryLlcQBEQIyhMbriQUODA55T5iWB8eCZvh27reC1jv4TQEwRzvFENjfArY8401X0gze
	W2oV3h9VWX0iqW+hhvAZH0QfsANo3jg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-250-jrbatm_pPjOH-NQTu_9MeA-1; Mon, 14 Feb 2022 04:58:54 -0500
X-MC-Unique: jrbatm_pPjOH-NQTu_9MeA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C39F46861;
	Mon, 14 Feb 2022 09:58:52 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.34])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 205B56D02A;
	Mon, 14 Feb 2022 09:58:51 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id E2FEB1800091; Mon, 14 Feb 2022 10:58:48 +0100 (CET)
Date: Mon, 14 Feb 2022 10:58:48 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase
Message-ID: <20220214095848.6tcqe5byzav2thtc@sirius.home.kraxel.org>
References: <20220125063318.862-1-min.m.xu@intel.com>
 <20220125063318.862-3-min.m.xu@intel.com>
 <20220127132412.oqizta4k7mbtclpb@sirius.home.kraxel.org>
 <PH0PR11MB5064E1DE4FC20F523A970684C5229@PH0PR11MB5064.namprd11.prod.outlook.com>
 <20220128102009.5iwa7vhhpkcsym4b@sirius.home.kraxel.org>
 <PH0PR11MB5064E1622E856375E49C722AC5339@PH0PR11MB5064.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB5064E1622E856375E49C722AC5339@PH0PR11MB5064.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> $ grep -rn --exclude-dir=Build PcdSevEsWorkAreaBase - UefiCpuPkg/Library/MpInitLib/AmdSev.c

There is 'git grep' btw.

> I would suggest Renaming PcdSevEsWorkAreaBase to PcdCcWorkAreaBase be in a separate patch-set. 
> Gerd, What's your thought?

Fine with me.

I'd suggest to (temporately) use PcdSevEsWorkAreaBase in tdx code then,
possibly with a comment explaining the situation and plans, so we avoid
the churn and confusion of adding and removing PcdTdxWorkAreaBase.

take care,
  Gerd