From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web09.32227.1644832871904750498
 for <devel@edk2.groups.io>;
 Mon, 14 Feb 2022 02:01:12 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Bhw52pof;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1644832871;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ll0OsdWWS6m6wBISRc1/jdhKJw/i9U0CP5U+VG7sj7Y=;
	b=Bhw52poffdbbezgZ6UkG0oaQtDTXgbYdbYrY9jLH9zhyzPV8Sv1jnoHuUcPNccDVfph+tY
	jRLRKZB20Vzz7cNp190usO/+5T2A4/kwrfJPIimfbUjfkZlagc4ko7oF7hNC2C85UU+uru
	jA+spDYJhB0fMvcmC6GiNKAZirq5OjY=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-504-4KiQdm5dNOKHsBHDydTEJQ-1; Mon, 14 Feb 2022 05:01:05 -0500
X-MC-Unique: 4KiQdm5dNOKHsBHDydTEJQ-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48B7D18A224B;
	Mon, 14 Feb 2022 10:01:04 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.34])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id F0E2C6D02A;
	Mon, 14 Feb 2022 10:01:03 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id B8ABA1800091; Mon, 14 Feb 2022 11:00:56 +0100 (CET)
Date: Mon, 14 Feb 2022 11:00:56 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V2 05/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings
Message-ID: <20220214100056.ls35il2eoxnbpvrc@sirius.home.kraxel.org>
References: <20220125063318.862-1-min.m.xu@intel.com>
 <20220125063318.862-6-min.m.xu@intel.com>
 <20220127133253.kiytvih2iiamzwah@sirius.home.kraxel.org>
 <PH0PR11MB50645B0DD05D940F00020FACC5339@PH0PR11MB5064.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB50645B0DD05D940F00020FACC5339@PH0PR11MB5064.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 14, 2022 at 02:34:30AM +0000, Xu, Min M wrote:
> Hi
> > > --- a/OvmfPkg/Include/IndustryStandard/IntelTdx.h
> > > +++ b/OvmfPkg/Include/IndustryStandard/IntelTdx.h
> > 
> > With this being more widely used it doesn't make sense to have it in
> > IntelTdx.h ...
> > 
> I am thinking EFI_HOB_PLATFORM_INFO can be declared at OvmfPkg/Include/Library/PlatformInitLib.h or we can create a new file (OvmfPkg/Include/IndustryStandard/Platform.h) to have it.

Using PlatformInitLib.h looks good to me.

take care,
  Gerd