From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.12355.1645534915129724270
 for <devel@edk2.groups.io>;
 Tue, 22 Feb 2022 05:01:56 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OSHWsG/P;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1645534914;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=x37YuUg9vVx/jqlgCal5/tlWdVb7sewEMKxBYML2bpc=;
	b=OSHWsG/PUJ9/9JDfoMVQAIUqvC1Yu4hnBncqhMq/skSEhWmpQqfVU4ZnwUmx/WTEOdFngl
	MHCz6XyZ0xPH8JvKCDmRYIwc4AG/0UvLySFjoxBUGNMEX025kTjdayA5vL7dMG++O1RBBj
	vs9usltM17LHYTkUXKXWJIPbBPEXb5s=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-470-IIeqR91oPm67p6zTNI59CA-1; Tue, 22 Feb 2022 08:00:49 -0500
X-MC-Unique: IIeqR91oPm67p6zTNI59CA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88C681091DB3;
	Tue, 22 Feb 2022 13:00:47 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 29A6483299;
	Tue, 22 Feb 2022 13:00:47 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 67041180079D; Tue, 22 Feb 2022 14:00:45 +0100 (CET)
Date: Tue, 22 Feb 2022 14:00:45 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V6 18/42] OvmfPkg/PlatformPei: Update Cmos functions with PlatformInitLib
Message-ID: <20220222130045.m5ue42qfxrbtmusi@sirius.home.kraxel.org>
References: <cover.1645261990.git.min.m.xu@intel.com>
 <b508e67022441917f01728479aa24caa46fde5b1.1645261990.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <b508e67022441917f01728479aa24caa46fde5b1.1645261990.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

>  OvmfPkg/PlatformPei/Cmos.c          | 55 -----------------------------
>  OvmfPkg/PlatformPei/Cmos.h          | 48 -------------------------

That kills the git history.  Better have adding the cmos function to
PlatformInitLib and removing them from PlatformPei in the same patch,
git will detect that you are effectively moving code then.

Ideally we'd have a one patch doing the buildsystem changes (add empty
PlatformInitLib and add the lib to .inf and .dsc files), and one patch
moving the cmos code over.  But given that the cmos code is rather small
I'm also fine with a single patch doing both (i.e. squash
this patch with #17).

take care,
  Gerd