From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.5576.1645608428411164522 for ; Wed, 23 Feb 2022 01:27:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=V3VBL7kT; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645608427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JP4N1TT6CFTi63K7o2/kLtBLpKcGLkNwLTOy1cZxf/Y=; b=V3VBL7kTWgnaZbNCZEny6zVb5eFas8dZ2t7PSSVDEGQC0Irk6AMjhVlXQM/qG687qzBbOH vn2qDbCW6dDmRVLIt7fNqmLZK1sABYykV3+BI/5617KQBnV9iUpoR46BWQzvhTKuBtQRHb K5M4ZjguVN+2tLLUMMbAMdO91/VWfjU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-330-3klAM5mWMLKw-D8FTvzvKw-1; Wed, 23 Feb 2022 04:27:04 -0500 X-MC-Unique: 3klAM5mWMLKw-D8FTvzvKw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D09871091DA0; Wed, 23 Feb 2022 09:27:02 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.195.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73D2C1053B2A; Wed, 23 Feb 2022 09:27:02 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 570CD18003BF; Wed, 23 Feb 2022 10:26:59 +0100 (CET) Date: Wed, 23 Feb 2022 10:26:59 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, min.m.xu@intel.com Cc: Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V6 26/42] OvmfPkg: Add null instance of PlatformInitLib Message-ID: <20220223092659.5u3h5o4ykrexekf4@sirius.home.kraxel.org> References: <20220222131009.oh3p5cfjupzvjkdp@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 23, 2022 at 12:34:21AM +0000, Min Xu wrote: > On February 22, 2022 9:10 PM, Gerd Hoffmann wrote: > > > > > > Add null instance of PlatformInitLib. > > > > What is this library needed for? > > In #25 (OvmfPkg: Update PlatformInitLib to process Tdx hoblist) ProcessTdxHobList is added in PlatformInitLib to process the Tdx HobList. This function is called in OvmfPkg/Sec/SecMain.c (#28 OvmfPkg: Update Sec to support Tdx). ProcessTdxHobList is called by OvmfPkg/IntelTdx/Sec/SecMain.c as well. See https://edk2.groups.io/g/devel/message/86120 > > OvmfPkg/Sec/SecMain.c is used by OvmfXen.dsc/AmdSevX64.dsc/BhyveX64.dsc/CloudHvX64.dsc/MicrovmX64.dsc. So PlatformInitLibNull is needed by these platforms. OK. So this is probably temporary thing until the other ovmf variants are switched over to use PlatformInitLib too? If so, can you add a comment saying so? With that added: Acked-by: Gerd Hoffmann