public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 7/8] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob
Date: Wed, 23 Feb 2022 12:03:35 +0100	[thread overview]
Message-ID: <20220223110335.pevax5cklskydbqc@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220220023319.1495-8-min.m.xu@intel.com>

>    //
>    // Query Host Bridge DID to determine platform type
> +  // Tdx guest stores the HostBridgePciDevId in a GuidHob.
> +  // So we first check if this HOB exists
>    //
> -  HostBridgeDevId = PcdGet16 (PcdOvmfHostBridgePciDevId);
> +  GuidHob = GetFirstGuidHob (&gUefiOvmfPkgTdxPlatformGuid);
> +  if (GuidHob != NULL) {
> +    PlatformInfo    = (EFI_HOB_PLATFORM_INFO *)GET_GUID_HOB_DATA (GuidHob);
> +    HostBridgeDevId = PlatformInfo->HostBridgePciDevId;
> +  } else {
> +    HostBridgeDevId = PcdGet16 (PcdOvmfHostBridgePciDevId);
> +  }

Another thing we can probably simplify when we use a PlatformInfoHob in
both PEi and PEI-less mode.

> +[Guids]
> +  gUefiOvmfPkgTdxPlatformGuid                      ## CONSUMES

name this UefiOvmfPkgPlatformInfoGuid ?

take care,
  Gerd


  reply	other threads:[~2022-02-23 11:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20  2:33 [PATCH V3 0/8] Introduce TDVF Config-B (basic) in OvmfPkg Min Xu
2022-02-20  2:33 ` [PATCH V3 1/8] OvmfPkg: Add TdxWorkArea definition Min Xu
2022-02-20  2:33 ` [PATCH V3 2/8] OvmfPkg: Add PrePiHobListPointerLibTdx Min Xu
2022-02-23 10:26   ` Gerd Hoffmann
2022-02-20  2:33 ` [PATCH V3 3/8] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings Min Xu
2022-02-23 10:27   ` Gerd Hoffmann
2022-02-20  2:33 ` [PATCH V3 4/8] OvmfPkg: Add TdxStartupLib Min Xu
2022-02-23 10:50   ` Gerd Hoffmann
2022-02-24  1:09     ` [edk2-devel] " Min Xu
2022-02-24  6:22       ` Gerd Hoffmann
2022-02-20  2:33 ` [PATCH V3 5/8] OvmfPkg/IntelTdx: Add Sec to bring up both Legacy and Tdx guest Min Xu
2022-02-23 10:53   ` Gerd Hoffmann
2022-02-20  2:33 ` [PATCH V3 6/8] OvmfPkg: Update TdxDxe to set TDX PCDs Min Xu
2022-02-23 10:58   ` Gerd Hoffmann
2022-02-20  2:33 ` [PATCH V3 7/8] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob Min Xu
2022-02-23 11:03   ` Gerd Hoffmann [this message]
2022-02-24  2:12     ` Min Xu
2022-02-20  2:33 ` [PATCH V3 8/8] OvmfPkg: Introduce IntelTdxX64 for TDVF Config-B Min Xu
2022-02-23 11:06   ` Gerd Hoffmann
2022-02-24  2:14     ` [edk2-devel] " Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220223110335.pevax5cklskydbqc@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox