From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web09.6202.1645614419861028312
 for <devel@edk2.groups.io>;
 Wed, 23 Feb 2022 03:07:00 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Z4JskK0L;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1645614419;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Q12602/lcatgo0EqriKySZ9sDuzWqLdx7jh5ktIgcBc=;
	b=Z4JskK0L56mCWMAWB3qaxHkVhlo/v3nspwVv2o5OMYt7V+GfbnVAM5y51XpXDbpomhk1ux
	pOEXvX2FkC7fsKWSEdXmUNpnC97WYI3WlSilZ1hmE3vkh4ZRqcaXBcU7y/7Z2ve9oHHago
	poOaWCazvOZEnmZMY3zV1uY2HiW9sQw=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-111-eO1AUqYrMSCA25QRt8QSuQ-1; Wed, 23 Feb 2022 06:06:55 -0500
X-MC-Unique: eO1AUqYrMSCA25QRt8QSuQ-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3B6C2801AAD;
	Wed, 23 Feb 2022 11:06:54 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id F0E6560C41;
	Wed, 23 Feb 2022 11:06:53 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 42BEB18003BA; Wed, 23 Feb 2022 12:06:52 +0100 (CET)
Date: Wed, 23 Feb 2022 12:06:52 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 8/8] OvmfPkg: Introduce IntelTdxX64 for TDVF Config-B
Message-ID: <20220223110652.hypwvfkci53ih2gp@sirius.home.kraxel.org>
References: <20220220023319.1495-1-min.m.xu@intel.com>
 <20220220023319.1495-9-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20220220023319.1495-9-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +  #
> +  # Defines for default states.  These can be changed on the command line.
> +  # -D FLAG=VALUE
> +  #
> +  DEFINE SECURE_BOOT_ENABLE      = FALSE

Will TDX support secure boot?  If not then this config switch can simply
be dropped (and the checks for SECURE_BOOT_ENABLE too).

Given this is just a minor cleanup:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd