From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, sebastien.boeuf@intel.com
Cc: jiewen.yao@intel.com, jordan.l.justen@intel.com
Subject: Re: [edk2-devel] [PATCH 1/3] OvmfPkg: Generate CloudHv as a PVH ELF binary
Date: Wed, 23 Feb 2022 12:22:13 +0100 [thread overview]
Message-ID: <20220223112213.j7fvqlswybnz3mt6@sirius.home.kraxel.org> (raw)
In-Reply-To: <54a8547ccdea2ae8fc5a58728f861d7019847369.1645542995.git.sebastien.boeuf@intel.com>
On Tue, Feb 22, 2022 at 04:53:04PM +0100, Boeuf, Sebastien wrote:
> From: Sebastien Boeuf <sebastien.boeuf@intel.com>
>
> Following the model from the Xen target, CloudHv is generated as a PVH
> ELF binary to take advantage of the PVH specification.
> --- /dev/null
> +++ b/OvmfPkg/CloudHv/CloudHvElfHeaderGenerator.c
Why create a new copy of this? What are the differences to the Xen
version? I guess they are small so we can maybe have a common
ElfPvhHeaderGenerator.c with command line switches?
> - OvmfPkg/ResetVector/ResetVector.inf
> + OvmfPkg/XenResetVector/XenResetVector.inf
Why this is needed?
> +DATA = {
> + #
> + # This hex array have been generated by OvmfPkg/OvmfXenElfHeaderGenerator.c
> + # and copied manually.
How about having the generator write a .fdf.inc file which you can just
include directly without manual copying?
take care,
Gerd
next prev parent reply other threads:[~2022-02-23 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1645542995.git.sebastien.boeuf@intel.com>
2022-02-22 15:53 ` [PATCH 1/3] OvmfPkg: Generate CloudHv as a PVH ELF binary Boeuf, Sebastien
2022-02-23 11:22 ` Gerd Hoffmann [this message]
2022-02-23 12:35 ` [edk2-devel] " Boeuf, Sebastien
2022-02-23 17:29 ` Boeuf, Sebastien
2022-02-24 6:27 ` Gerd Hoffmann
2022-02-24 14:35 ` Boeuf, Sebastien
2022-02-22 15:53 ` [PATCH 2/3] OvmfPkg: CloudHv: Retrieve RSDP address from PVH Boeuf, Sebastien
2022-02-23 11:31 ` [edk2-devel] " Gerd Hoffmann
2022-02-24 14:41 ` Boeuf, Sebastien
2022-02-25 9:34 ` Gerd Hoffmann
2022-02-22 15:53 ` [PATCH 3/3] OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS Boeuf, Sebastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223112213.j7fvqlswybnz3mt6@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox