From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web12.6191.1645615341741025632
 for <devel@edk2.groups.io>;
 Wed, 23 Feb 2022 03:22:22 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hualb68k;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1645615340;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=40Uj6b+K/Fy4aWj7jQi92vzJxYSaYeKu2kTzAwznQ/o=;
	b=Hualb68kenxJe5v+2VnoorIIj6PUkPNP8bVPORPIuhNZ8k67cofiZzpBE/FJJZUD8Mvumn
	l/XpZUIM0TepbnT/JYdJ99cEKyhP9UtURTOReQ1+INGb6YGJo0kGBwmHtN0AH+nbtnrsxo
	wUpZhJZb+iEdvhNtqbYy7/h9rmh9U8Q=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-347-lJ_Dv57eO_-tFf8XLqahAw-1; Wed, 23 Feb 2022 06:22:17 -0500
X-MC-Unique: lJ_Dv57eO_-tFf8XLqahAw-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1BC8824FA7;
	Wed, 23 Feb 2022 11:22:15 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 8428F7B8CB;
	Wed, 23 Feb 2022 11:22:15 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id AA0E318003BA; Wed, 23 Feb 2022 12:22:13 +0100 (CET)
Date: Wed, 23 Feb 2022 12:22:13 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, sebastien.boeuf@intel.com
Cc: jiewen.yao@intel.com, jordan.l.justen@intel.com
Subject: Re: [edk2-devel] [PATCH 1/3] OvmfPkg: Generate CloudHv as a PVH ELF binary
Message-ID: <20220223112213.j7fvqlswybnz3mt6@sirius.home.kraxel.org>
References: <cover.1645542995.git.sebastien.boeuf@intel.com>
 <54a8547ccdea2ae8fc5a58728f861d7019847369.1645542995.git.sebastien.boeuf@intel.com>
MIME-Version: 1.0
In-Reply-To: <54a8547ccdea2ae8fc5a58728f861d7019847369.1645542995.git.sebastien.boeuf@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 22, 2022 at 04:53:04PM +0100, Boeuf, Sebastien wrote:
> From: Sebastien Boeuf <sebastien.boeuf@intel.com>
> 
> Following the model from the Xen target, CloudHv is generated as a PVH
> ELF binary to take advantage of the PVH specification.

> --- /dev/null
> +++ b/OvmfPkg/CloudHv/CloudHvElfHeaderGenerator.c

Why create a new copy of this?  What are the differences to the Xen
version?  I guess they are small so we can maybe have a common
ElfPvhHeaderGenerator.c with command line switches?

> -  OvmfPkg/ResetVector/ResetVector.inf
> +  OvmfPkg/XenResetVector/XenResetVector.inf

Why this is needed?

> +DATA = {
> +  #
> +  # This hex array have been generated by OvmfPkg/OvmfXenElfHeaderGenerator.c
> +  # and copied manually.

How about having the generator write a .fdf.inc file which you can just
include directly without manual copying?

take care,
  Gerd