From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.6371.1645615926159690722
 for <devel@edk2.groups.io>;
 Wed, 23 Feb 2022 03:32:06 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b4HAxZtZ;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1645615925;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=pgptkuPOuiEH4EDpoKiLXsXYBhj23EdFHIQfyBmhxSo=;
	b=b4HAxZtZdF6RQlMJV6U3tMc/1y2TG5tl/tJrjdKl96HL2GZQRTETPOXIwi5ypzD9e605RM
	yqUpi8Pgvv8T1CfBgGF78O4fTrreVaewE/mGkhvqYBXQfC2jolqrlkXWgF9hOjyVHkkPhw
	gaR3PRi5hY5JcPNrkI9+XCMCUeiStcA=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-620-SuF5ZOacOq-hkTfNz4ZNvQ-1; Wed, 23 Feb 2022 06:32:02 -0500
X-MC-Unique: SuF5ZOacOq-hkTfNz4ZNvQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3913A801AAD;
	Wed, 23 Feb 2022 11:32:00 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 01940105C87D;
	Wed, 23 Feb 2022 11:31:59 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 5494618003BA; Wed, 23 Feb 2022 12:31:58 +0100 (CET)
Date: Wed, 23 Feb 2022 12:31:58 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, sebastien.boeuf@intel.com
Cc: jiewen.yao@intel.com, jordan.l.justen@intel.com
Subject: Re: [edk2-devel] [PATCH 2/3] OvmfPkg: CloudHv: Retrieve RSDP address from PVH
Message-ID: <20220223113158.5n4jxj7n7n63zjft@sirius.home.kraxel.org>
References: <cover.1645542995.git.sebastien.boeuf@intel.com>
 <58817971e9b3974f19e6b1daee12580d47d612cd.1645542995.git.sebastien.boeuf@intel.com>
MIME-Version: 1.0
In-Reply-To: <58817971e9b3974f19e6b1daee12580d47d612cd.1645542995.git.sebastien.boeuf@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +  PVHResetVectorData = (VOID *)(UINTN)PcdGet32 (PcdXenPvhStartOfDayStructPtr);
> +  pvh_start_info       = (struct hvm_start_info *)(UINTN)PVHResetVectorData[0];

Ah, I see, here is the xen reset vector dependency.

I'm wondering whenever there are plans for cloudhv to also support sev
and/or tdx some day.  If so, then it probably isn't a good idea to
switch to the xen reset vector.  There is the work area used for by
confidential computing code, I think it would be an option to store a
pointer to the pvh_start_info there.

take care,
  Gerd