From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/3] OvmfPkg: Generate CloudHv as a PVH ELF binary
Date: Thu, 24 Feb 2022 07:27:36 +0100 [thread overview]
Message-ID: <20220224062736.mf7vrbnjfbi3g3un@sirius.home.kraxel.org> (raw)
In-Reply-To: <d78b66e0d37661565ab6069586d633419f330fde.camel@intel.com>
> > > +DATA = {
> > > + #
> > > + # This hex array have been generated by
> > > OvmfPkg/OvmfXenElfHeaderGenerator.c
> > > + # and copied manually.
> >
> > How about having the generator write a .fdf.inc file which you can
> > just
> > include directly without manual copying?
>
> I understand the idea, but do you have any pointer to some existing
> code in the repo already doing such thing?
I'd suggest to just commit the generated include file to git instead of
hooking the generator call into the build system, i.e. updating it would
still be a manual process, but easier and less error-prone because the
manual copying goes away.
take care,
Gerd
next prev parent reply other threads:[~2022-02-24 6:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1645542995.git.sebastien.boeuf@intel.com>
2022-02-22 15:53 ` [PATCH 1/3] OvmfPkg: Generate CloudHv as a PVH ELF binary Boeuf, Sebastien
2022-02-23 11:22 ` [edk2-devel] " Gerd Hoffmann
2022-02-23 12:35 ` Boeuf, Sebastien
2022-02-23 17:29 ` Boeuf, Sebastien
2022-02-24 6:27 ` Gerd Hoffmann [this message]
2022-02-24 14:35 ` Boeuf, Sebastien
2022-02-22 15:53 ` [PATCH 2/3] OvmfPkg: CloudHv: Retrieve RSDP address from PVH Boeuf, Sebastien
2022-02-23 11:31 ` [edk2-devel] " Gerd Hoffmann
2022-02-24 14:41 ` Boeuf, Sebastien
2022-02-25 9:34 ` Gerd Hoffmann
2022-02-22 15:53 ` [PATCH 3/3] OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS Boeuf, Sebastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224062736.mf7vrbnjfbi3g3un@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox