From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.7254.1645684065321092306
 for <devel@edk2.groups.io>;
 Wed, 23 Feb 2022 22:27:46 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cr/bSzH8;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1645684064;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2QZI6x4n8LQZ3uSs+tfRdMvLk8cpvanUHnmACqCJhnY=;
	b=cr/bSzH8+xLi9Y+ws/fQBU+XWXvVfUC/Wq5g0eWZTEgBjFDzlcKhgnJhe+GsjCX2hNf4qm
	IM4EFLExVKVJF4YBFpDRm2wB/MH49E0aMKgEZgs7LONIVpqajHc3tY9Xbx62+/BZskc6Cq
	nqgS4Czxi1+uASlcq6j5hhsXJeWjs5g=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-248-sR3fLmmeNpqPXjQWS3dQnw-1; Thu, 24 Feb 2022 01:27:39 -0500
X-MC-Unique: sR3fLmmeNpqPXjQWS3dQnw-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 93CE3800482;
	Thu, 24 Feb 2022 06:27:38 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B8C06E6EC;
	Thu, 24 Feb 2022 06:27:38 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id CDAF018000B4; Thu, 24 Feb 2022 07:27:36 +0100 (CET)
Date: Thu, 24 Feb 2022 07:27:36 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/3] OvmfPkg: Generate CloudHv as a PVH ELF binary
Message-ID: <20220224062736.mf7vrbnjfbi3g3un@sirius.home.kraxel.org>
References: <cover.1645542995.git.sebastien.boeuf@intel.com>
 <54a8547ccdea2ae8fc5a58728f861d7019847369.1645542995.git.sebastien.boeuf@intel.com>
 <20220223112213.j7fvqlswybnz3mt6@sirius.home.kraxel.org>
 <d78b66e0d37661565ab6069586d633419f330fde.camel@intel.com>
MIME-Version: 1.0
In-Reply-To: <d78b66e0d37661565ab6069586d633419f330fde.camel@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

> > > +DATA = {
> > > +  #
> > > +  # This hex array have been generated by
> > > OvmfPkg/OvmfXenElfHeaderGenerator.c
> > > +  # and copied manually.
> > 
> > How about having the generator write a .fdf.inc file which you can
> > just
> > include directly without manual copying?
> 
> I understand the idea, but do you have any pointer to some existing
> code in the repo already doing such thing?

I'd suggest to just commit the generated include file to git instead of
hooking the generator call into the build system, i.e. updating it would
still be a manual process, but easier and less error-prone because the
manual copying goes away.

take care,
  Gerd