From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.7836.1645690586070337946
 for <devel@edk2.groups.io>;
 Thu, 24 Feb 2022 00:16:26 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=idQYNJ5P;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1645690585;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=s9I6AEMYswzf6uFOxYsENnO8sOAWnzbxlSvyMqhunHY=;
	b=idQYNJ5PF2pjdbutpPZd8EB4onU1FM+yLz0VtlOtGrlqJGqCf23UiM/w2wI0C0yNLnM1z2
	qsef51yyxa6fZ7E7Pz3ome4sclpctUbgeA5AV4k6aeC5MI2c9orWkqGwCr6qitNNwS91k9
	wt59N8Ot3Tpgn4YDTVg/FnjRHd6gZ1c=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-341-DexGlyh-OLODHPzz1xEjcA-1; Thu, 24 Feb 2022 03:16:22 -0500
X-MC-Unique: DexGlyh-OLODHPzz1xEjcA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52BF151A9;
	Thu, 24 Feb 2022 08:16:21 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0EFF27FA2A;
	Thu, 24 Feb 2022 08:16:21 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 487D218000B4; Thu, 24 Feb 2022 09:16:19 +0100 (CET)
Date: Thu, 24 Feb 2022 09:16:19 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: sebastien.boeuf@intel.com
Cc: devel@edk2.groups.io, jiewen.yao@intel.com, jordan.l.justen@intel.com
Subject: Re: [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary
Message-ID: <20220224081619.acofqxps4s4pb2dv@sirius.home.kraxel.org>
References: <cover.1645634879.git.sebastien.boeuf@intel.com>
 <f11507a342f24f1a41e4d0f64e4bae9c634c9576.1645634879.git.sebastien.boeuf@intel.com>
MIME-Version: 1.0
In-Reply-To: <f11507a342f24f1a41e4d0f64e4bae9c634c9576.1645634879.git.sebastien.boeuf@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> -!include OvmfPkg/VarStore.fdf.inc
> +!if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048)
> +0x00000000|0x0000e000
> +!endif
> +!if $(FD_SIZE_IN_KB) == 4096
> +0x00000000|0x00040000
> +!endif

Hmm, VarStore.fdf.inc reduces duplication, and now you revert this.
Maybe add this to VarStore.fdf.inc instead, and add a PVH_HEADER_ENABLE
option to turn it on and off?

Also: With this in place the start of the vars firmware volume moves
because it's prefixed by the elf header.  Does that work without code
changes?

take care,
  Gerd