public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary
Date: Fri, 25 Feb 2022 10:29:54 +0100	[thread overview]
Message-ID: <20220225092954.t2ghpi2dl4ketbcf@sirius.home.kraxel.org> (raw)
In-Reply-To: <45801ff195bd62ad7c8f86f93d1d59eff09434a9.camel@intel.com>

  Hi,

> > Hmm, VarStore.fdf.inc reduces duplication, and now you revert this.
> > Maybe add this to VarStore.fdf.inc instead, and add a
> > PVH_HEADER_ENABLE
> > option to turn it on and off?
> 
> It's quite hard to use VarStore.fdf.inc since I would need to replace
> only the first DATA section. And I can't include something specific
> like OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc inside VarStore.fdf.inc.
> Should I create something like OvmfPkg/CloudHv/CloudHvVarStore.fdf.inc
> so that it makes sense to include
> OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc based on a PVH_HEADER_ENABLE
> variable?

Yes, that was the idea, only include the file in case
PVH_HEADER_ENABLE=TRUE.  Maybe name it "PVH_HEADER_CLOUDHW" so the xen
guys can add PVH_HEADER_XEN variable for the simliar but not identical
xen case.

take care,
  Gerd


  reply	other threads:[~2022-02-25  9:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 16:51 [PATCH v2 0/5] CloudHv: Rely on PVH boot specification Boeuf, Sebastien
2022-02-23 16:51 ` [PATCH v2 1/5] OvmfPkg: Make the Xen ELF header generator more flexible Boeuf, Sebastien
2022-02-24  8:07   ` Gerd Hoffmann
2022-02-23 16:51 ` [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary Boeuf, Sebastien
2022-02-24  8:16   ` Gerd Hoffmann
2022-02-24 15:12     ` [edk2-devel] " Boeuf, Sebastien
2022-02-25  9:29       ` Gerd Hoffmann [this message]
2022-02-25 10:49         ` Boeuf, Sebastien
2022-02-23 16:51 ` [PATCH v2 3/5] OvmfPkg: CloudHv: Retrieve RSDP address from PVH Boeuf, Sebastien
2022-02-23 16:51 ` [PATCH v2 4/5] OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS Boeuf, Sebastien
2022-02-23 16:51 ` [PATCH v2 5/5] OvmfPkg: CloudHv: Add README Boeuf, Sebastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220225092954.t2ghpi2dl4ketbcf@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox