From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web12.4875.1645781403890973399
 for <devel@edk2.groups.io>;
 Fri, 25 Feb 2022 01:30:04 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gNEL4JA1;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1645781402;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=K3m0m18eZNNfA8II6IrTK8qVwMgHoeBBHs6Z6hyAu2Q=;
	b=gNEL4JA1Wvx7mrTGmOv2Lql6HrB9FSj0SpjagvxFFtn/97mvsZ0OXDGcr3qxvNobFy1gzY
	siZ66WourCr8VFSmEPiE/1fxLcnHA3ioHjsHVtZ3nI1BcyAmDlozMdVaObvW6BAnos5b9W
	czjHcosmxKne9niOmDWep0Kqq0Rg5/4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-571-x48KnibJMfGauU_PwErR-g-1; Fri, 25 Feb 2022 04:29:58 -0500
X-MC-Unique: x48KnibJMfGauU_PwErR-g-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EB498800425;
	Fri, 25 Feb 2022 09:29:56 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F2461038AC9;
	Fri, 25 Feb 2022 09:29:56 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 341C418003BE; Fri, 25 Feb 2022 10:29:54 +0100 (CET)
Date: Fri, 25 Feb 2022 10:29:54 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary
Message-ID: <20220225092954.t2ghpi2dl4ketbcf@sirius.home.kraxel.org>
References: <cover.1645634879.git.sebastien.boeuf@intel.com>
 <f11507a342f24f1a41e4d0f64e4bae9c634c9576.1645634879.git.sebastien.boeuf@intel.com>
 <20220224081619.acofqxps4s4pb2dv@sirius.home.kraxel.org>
 <45801ff195bd62ad7c8f86f93d1d59eff09434a9.camel@intel.com>
MIME-Version: 1.0
In-Reply-To: <45801ff195bd62ad7c8f86f93d1d59eff09434a9.camel@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > Hmm, VarStore.fdf.inc reduces duplication, and now you revert this.
> > Maybe add this to VarStore.fdf.inc instead, and add a
> > PVH_HEADER_ENABLE
> > option to turn it on and off?
> 
> It's quite hard to use VarStore.fdf.inc since I would need to replace
> only the first DATA section. And I can't include something specific
> like OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc inside VarStore.fdf.inc.
> Should I create something like OvmfPkg/CloudHv/CloudHvVarStore.fdf.inc
> so that it makes sense to include
> OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc based on a PVH_HEADER_ENABLE
> variable?

Yes, that was the idea, only include the file in case
PVH_HEADER_ENABLE=TRUE.  Maybe name it "PVH_HEADER_CLOUDHW" so the xen
guys can add PVH_HEADER_XEN variable for the simliar but not identical
xen case.

take care,
  Gerd