From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web09.4929.1645781738146354356
 for <devel@edk2.groups.io>;
 Fri, 25 Feb 2022 01:35:38 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GkPO6nTu;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1645781737;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=NJwBFdE2Lbobgh9YKK8FJJI/nJ7P7aAgY+kEY5Lqf1c=;
	b=GkPO6nTu9qb+aKLduvgFQc6/B5MLM7BRRW8Jd8QSVdTCY7Z1NhIqxPZuefMe/pcH5tLsnK
	GKn8M6a6DeIBe/P7qnpyGibacqCbytWDM65hLuU88pJILudsPKZbK2Kiet+jnMZvoM2rdy
	AR9oPJz0fqiiyAwx7s9hUBZURMGqbfg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-623-adays3uMMDOorNw4sOBhYg-1; Fri, 25 Feb 2022 04:35:35 -0500
X-MC-Unique: adays3uMMDOorNw4sOBhYg-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F1AE180FD71;
	Fri, 25 Feb 2022 09:35:34 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 44A3F76C30;
	Fri, 25 Feb 2022 09:35:34 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 7EF2218003BE; Fri, 25 Feb 2022 10:35:32 +0100 (CET)
Date: Fri, 25 Feb 2022 10:35:32 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: sebastien.boeuf@intel.com
Cc: devel@edk2.groups.io, jiewen.yao@intel.com, jordan.l.justen@intel.com
Subject: Re: [PATCH v3 1/7] OvmfPkg: Make the Xen ELF header generator more flexible
Message-ID: <20220225093532.2gdfcbdviya3365a@sirius.home.kraxel.org>
References: <cover.1645712595.git.sebastien.boeuf@intel.com>
 <472341415f3f5d70049e9a5a3ad304ba3293db18.1645712595.git.sebastien.boeuf@intel.com>
MIME-Version: 1.0
In-Reply-To: <472341415f3f5d70049e9a5a3ad304ba3293db18.1645712595.git.sebastien.boeuf@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Feb 24, 2022 at 03:28:20PM +0100, sebastien.boeuf@intel.com wrote:
> From: Sebastien Boeuf <sebastien.boeuf@intel.com>
> 
> Adding some flexibility to the program through optional parameters and
> global define, so that other targets can use the generator.
> 
> * A global define is added so that we can choose at build time if we
>   want to use 32-bit or 64-bit base structures.
> * A first optional parameter is added so the user can provide the
>   expected blob size of the generated binary.
> * A second optional parameter is added so the user can specify an output
>   file to which the generated output will be printed.
> 
> The default behavior isn't modified.
> 
> Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>