From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, sebastien.boeuf@intel.com
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH v4 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary
Date: Tue, 1 Mar 2022 08:16:26 +0100 [thread overview]
Message-ID: <20220301071626.c2hfo3x6axmzda5h@sirius.home.kraxel.org> (raw)
In-Reply-To: <0249616033ac624041e9c3f5c5f6fb37e6a178a7.camel@intel.com>
On Mon, Feb 28, 2022 at 03:12:53PM +0000, Boeuf, Sebastien wrote:
> So what do you think I should do with this patch?
I think you can:
(1) drop FD.CLOUDHV_VARS
(2) drop FD.CLOUDHV_CODE
(3) make VARS_SIZE smaller (just enough for the pvh header),
(4) make FVMAIN_SIZE larger (so the total size remains the same).
(5) possibly rename VARS_SIZE. It's not about VARS any more. Not
sure this is worth the churn and how many places you need to touch
for this, maybe a big'n'fat comment instead will do.
HTH,
Gerd
next prev parent reply other threads:[~2022-03-01 7:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 10:45 [PATCH v4 0/7] CloudHv: Rely on PVH boot specification Boeuf, Sebastien
2022-02-25 10:45 ` [PATCH v4 1/7] OvmfPkg: Make the Xen ELF header generator more flexible Boeuf, Sebastien
2022-02-25 10:45 ` [PATCH v4 2/7] OvmfPkg: Xen: Use a new fdf include for the PVH ELF header Boeuf, Sebastien
2022-02-25 10:45 ` [PATCH v4 3/7] OvmfPkg: Xen: Generate fdf include file from ELF header generator Boeuf, Sebastien
2022-02-25 10:45 ` [PATCH v4 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary Boeuf, Sebastien
2022-02-25 13:00 ` Gerd Hoffmann
2022-02-25 14:00 ` [edk2-devel] " Boeuf, Sebastien
2022-02-28 7:08 ` Gerd Hoffmann
2022-02-28 8:15 ` Boeuf, Sebastien
[not found] ` <16D7E5267B34FC87.32375@groups.io>
2022-02-28 15:12 ` Boeuf, Sebastien
2022-03-01 7:16 ` Gerd Hoffmann [this message]
2022-03-01 8:53 ` Boeuf, Sebastien
2022-03-01 11:28 ` Gerd Hoffmann
2022-03-01 13:30 ` Boeuf, Sebastien
[not found] ` <16D835C7D9FE3DA1.466@groups.io>
2022-03-01 9:17 ` Boeuf, Sebastien
2022-02-25 10:45 ` [PATCH v4 5/7] OvmfPkg: CloudHv: Retrieve RSDP address from PVH Boeuf, Sebastien
2022-02-25 10:45 ` [PATCH v4 6/7] OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS Boeuf, Sebastien
2022-02-25 10:45 ` [PATCH v4 7/7] OvmfPkg: CloudHv: Add README Boeuf, Sebastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301071626.c2hfo3x6axmzda5h@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox