From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.5690.1646118994556944460
 for <devel@edk2.groups.io>;
 Mon, 28 Feb 2022 23:16:35 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OhfRL4Ym;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1646118992;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ECqjp0SDZDFZySugdJk0UIe2+4NG7N2i3UhzDAHTg9s=;
	b=OhfRL4YmkBY+GDeR561yM08uovXjVKL23t/h7YTafAr1qYSYzu5ozkdvl9I/so2L1GF0ie
	9FiHB7QZEn097/0cCaMRAbnny3T/rib1rOn/mxwYtChF4i2Ca7w6vT8WZ6EglNN0xHDahO
	DnwmmczvD44MuReauQyLxnKP8iqvHk4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-567-LsBlbCY-MqiqLNWPqCUkPw-1; Tue, 01 Mar 2022 02:16:29 -0500
X-MC-Unique: LsBlbCY-MqiqLNWPqCUkPw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D5981854E2A;
	Tue,  1 Mar 2022 07:16:28 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id EB2D2827B0;
	Tue,  1 Mar 2022 07:16:27 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 07331180039D; Tue,  1 Mar 2022 08:16:26 +0100 (CET)
Date: Tue, 1 Mar 2022 08:16:26 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, sebastien.boeuf@intel.com
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH v4 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary
Message-ID: <20220301071626.c2hfo3x6axmzda5h@sirius.home.kraxel.org>
References: <cover.1645785801.git.sebastien.boeuf@intel.com>
 <b2e66b0e64bf6f0bed4d4b92df5a433e348e4c44.1645785801.git.sebastien.boeuf@intel.com>
 <20220225130053.oizxc47lhvyr5cim@sirius.home.kraxel.org>
 <405b52b1df1cfb1989005334555e7163376877b2.camel@intel.com>
 <20220228070808.ao753pdtfupp3qs4@sirius.home.kraxel.org>
 <16D7E5267B34FC87.32375@groups.io>
 <0249616033ac624041e9c3f5c5f6fb37e6a178a7.camel@intel.com>
MIME-Version: 1.0
In-Reply-To: <0249616033ac624041e9c3f5c5f6fb37e6a178a7.camel@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 28, 2022 at 03:12:53PM +0000, Boeuf, Sebastien wrote:
> So what do you think I should do with this patch?

I think you can:

  (1) drop FD.CLOUDHV_VARS
  (2) drop FD.CLOUDHV_CODE
  (3) make VARS_SIZE smaller (just enough for the pvh header),
  (4) make FVMAIN_SIZE larger (so the total size remains the same).
  (5) possibly rename VARS_SIZE.  It's not about VARS any more.  Not
      sure this is worth the churn and how many places you need to touch
      for this, maybe a big'n'fat comment instead will do.

HTH,
  Gerd