From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.7062.1646134102357226901
 for <devel@edk2.groups.io>;
 Tue, 01 Mar 2022 03:28:22 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MLAddv7W;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1646134101;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gBttrrgt+iCWUIfUYBZ+N3/lXXAR05mUGIvBp6xA8iE=;
	b=MLAddv7WDAAolqPZ8xlPz4xVg1zycyvmhoNoVSwg4+buB6Pk8iFu9sG0RpSr/KVXjBEg5L
	oXGJj455o91twlbqL+b5lttYy+Kgfk4wp/KRJTCbln4BJ8wgqVky0FtJnESU0Fth/amxL1
	pU+pnWaX7QJSMjF6/WncXhR+QW2w/Us=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-650-LMO7ywCTPJqMsSRGvpxWoQ-1; Tue, 01 Mar 2022 06:28:18 -0500
X-MC-Unique: LMO7ywCTPJqMsSRGvpxWoQ-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 475B8520F;
	Tue,  1 Mar 2022 11:28:17 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E2914EC7E;
	Tue,  1 Mar 2022 11:28:17 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 49246180039D; Tue,  1 Mar 2022 12:28:15 +0100 (CET)
Date: Tue, 1 Mar 2022 12:28:15 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH v4 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary
Message-ID: <20220301112815.berthmw6hgklyyym@sirius.home.kraxel.org>
References: <cover.1645785801.git.sebastien.boeuf@intel.com>
 <b2e66b0e64bf6f0bed4d4b92df5a433e348e4c44.1645785801.git.sebastien.boeuf@intel.com>
 <20220225130053.oizxc47lhvyr5cim@sirius.home.kraxel.org>
 <405b52b1df1cfb1989005334555e7163376877b2.camel@intel.com>
 <20220228070808.ao753pdtfupp3qs4@sirius.home.kraxel.org>
 <16D7E5267B34FC87.32375@groups.io>
 <0249616033ac624041e9c3f5c5f6fb37e6a178a7.camel@intel.com>
 <20220301071626.c2hfo3x6axmzda5h@sirius.home.kraxel.org>
 <0e04bc6e448959450adfb848ef65c3084525e868.camel@intel.com>
MIME-Version: 1.0
In-Reply-To: <0e04bc6e448959450adfb848ef65c3084525e868.camel@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Tue, Mar 01, 2022 at 08:53:10AM +0000, Boeuf, Sebastien wrote:
> On Tue, 2022-03-01 at 08:16 +0100, Gerd Hoffmann wrote:
> > On Mon, Feb 28, 2022 at 03:12:53PM +0000, Boeuf, Sebastien wrote:
> > > So what do you think I should do with this patch?
> > 
> > I think you can:
> > 
> >   (1) drop FD.CLOUDHV_VARS
> Ok
> >   (2) drop FD.CLOUDHV_CODE
> Ok
> >   (3) make VARS_SIZE smaller (just enough for the pvh header),
> 
> Ok. Do you want me to keep the factorization in VarStore.fdf.inc?

I think you don't need VarStore.fdf.inc? at all if you don't have a
varstore anyway.

take care,
  Gerd