From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.7442.1646138037437535969
 for <devel@edk2.groups.io>;
 Tue, 01 Mar 2022 04:33:58 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bfL586PI;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1646138036;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=c4WDzAhkuWKaOnZHS2Z/Ait9/fFx56udgAcRcTbNAIg=;
	b=bfL586PIkF6i7G+HS+MIvDFyotDJuWYAYjMCyEH1hDhpHL7UdaGzkVHxP+BFjtMzv7wPAV
	RAhVfRjFTZR/sVRypzjQ4wi6ZqVxxq8zZdsFCUYkwE1I9mFAlmYRskbUmCVupKUxobbCIS
	8VYFhZi0woy4InP5ldIUPSu43D9JGaY=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-474-Ekr5pQ7ZMIGz5Zw6mqujuQ-1; Tue, 01 Mar 2022 07:33:52 -0500
X-MC-Unique: Ekr5pQ7ZMIGz5Zw6mqujuQ-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 68341835DE0;
	Tue,  1 Mar 2022 12:33:51 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 19A4B84947;
	Tue,  1 Mar 2022 12:33:51 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 87131180039D; Tue,  1 Mar 2022 13:33:48 +0100 (CET)
Date: Tue, 1 Mar 2022 13:33:48 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V7 18/37] OvmfPkg/PlatformInitLib: Add hob functions
Message-ID: <20220301123348.ruzbww35uixxqlru@sirius.home.kraxel.org>
References: <cover.1646031164.git.min.m.xu@intel.com>
 <6a17988a92fe345dd2d70084a91d1614fd4cc318.1646031164.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <6a17988a92fe345dd2d70084a91d1614fd4cc318.1646031164.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 28, 2022 at 03:20:50PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> 
> In this patch of PlatformInitLib, below hob functions are introduced:
>  - PlatformAddIoMemoryBaseSizeHob
>  - PlatformAddIoMemoryRangeHob
>  - PlatformAddMemoryBaseSizeHob
>  - PlatformAddMemoryRangeHob
>  - PlatformAddReservedMemoryBaseSizeHob
> 
> They correspond the below functions in OvmfPkg/PlatformPei:
>  - AddIoMemoryBaseSizeHob
>  - AddIoMemoryRangeHob
>  - AddMemoryBaseSizeHob
>  - AddMemoryRangeHob
>  - AddReservedMemoryBaseSizeHob
> 
> After above hob functions are introduced in PlatformInitLib,
> OvmfPkg/PlatformPei is refactored with this library.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>