From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web09.8007.1646141218178983548
 for <devel@edk2.groups.io>;
 Tue, 01 Mar 2022 05:26:58 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MZK6/vZm;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1646141217;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=mcjLiu9b/wKfB37qWdng0tajKrY2nzPrg9m8egXR0zY=;
	b=MZK6/vZmawvwaGZUHbVoX3H7nNTLXILph0pgRebYf77apmCYVQXntGMQ81aWrvjyuz4c65
	1udeuKCu2NQ7btDJA7dV/sQrFgMDyxLYhBD0FxPzINYsVEQCUDabvNltPWlh5b0lVCq4Ol
	vqv0GpsfTFPQo8GQMKJlgVLSbZavKW4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-466-KQ4h0AahPG2D12Hgz6acog-1; Tue, 01 Mar 2022 08:26:56 -0500
X-MC-Unique: KQ4h0AahPG2D12Hgz6acog-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9DCBF1091DA0;
	Tue,  1 Mar 2022 13:26:54 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.81])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 14FBC7C0F7;
	Tue,  1 Mar 2022 13:26:54 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 57266180039D; Tue,  1 Mar 2022 14:26:52 +0100 (CET)
Date: Tue, 1 Mar 2022 14:26:52 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V4 03/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings
Message-ID: <20220301132652.mfdms3yevnnhpvp6@sirius.home.kraxel.org>
References: <20220228081631.681-1-min.m.xu@intel.com>
 <20220228081631.681-4-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20220228081631.681-4-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> @@ -15,6 +15,22 @@
>  typedef struct {
>    EFI_HOB_GUID_TYPE    GuidHeader;
>    UINT16               HostBridgePciDevId;
> +  BOOLEAN              PcdSetNxForStack;
> +
> +  UINT64               PcdConfidentialComputingGuestAttr;
> +  BOOLEAN              PcdIa32EferChangeAllowed;
> +  UINT64               PcdTdxSharedBitMask;
> +
> +  UINT64               PcdPciMmio64Base;
> +  UINT64               PcdPciMmio64Size;
> +  UINT32               PcdPciMmio32Base;
> +  UINT32               PcdPciMmio32Size;
> +  UINT64               PcdPciIoBase;
> +  UINT64               PcdPciIoSize;

Ah, here you add some of them to PLATFORM_INFO already ...

take care,
  Gerd