From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, sebastien.boeuf@intel.com
Cc: jiewen.yao@intel.com, jordan.l.justen@intel.com
Subject: Re: [edk2-devel] [PATCH v5 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary
Date: Wed, 2 Mar 2022 08:17:13 +0100 [thread overview]
Message-ID: <20220302071713.4kooi46ox3o6mu7h@sirius.home.kraxel.org> (raw)
In-Reply-To: <c45dc330afdc2d1a4be83c299ed7e57e3b0b7692.1646141266.git.sebastien.boeuf@intel.com>
> -[FD.CLOUDHV_VARS]
> -[FD.CLOUDHV_CODE]
Dropping these two should be a separate patch,
so this patch becomes more readable.
> -0x00000000|$(FVMAIN_SIZE)
> +0x00001000|$(FVMAIN_SIZE)
FVMAIN_SIZE is not changes anywhere it seems.
So CLOUDHV.fd ends up with some odd size (instead of 2M or 4M) I guess?
(not much of a problem though if cloudhv doesn't care ...)
> diff --git a/OvmfPkg/VarStore.fdf.inc b/OvmfPkg/VarStore.fdf.inc
> index a1e524e393..a1cbc74fbb 100644
> --- a/OvmfPkg/VarStore.fdf.inc
> +++ b/OvmfPkg/VarStore.fdf.inc
> @@ -15,6 +15,7 @@
> 0x00000000|0x00040000
> !endif
> #NV_VARIABLE_STORE
> +
> DATA = {
> ## This is the EFI_FIRMWARE_VOLUME_HEADER
> # ZeroVector []
leftover whitespace update
take care,
Gerd
next prev parent reply other threads:[~2022-03-02 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 13:29 [PATCH v5 0/7] CloudHv: Rely on PVH boot specification Boeuf, Sebastien
2022-03-01 13:29 ` [PATCH v5 1/7] OvmfPkg: Make the Xen ELF header generator more flexible Boeuf, Sebastien
2022-03-01 13:29 ` [PATCH v5 2/7] OvmfPkg: Xen: Use a new fdf include for the PVH ELF header Boeuf, Sebastien
2022-03-01 13:29 ` [PATCH v5 3/7] OvmfPkg: Xen: Generate fdf include file from ELF header generator Boeuf, Sebastien
2022-03-01 13:29 ` [PATCH v5 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary Boeuf, Sebastien
2022-03-02 7:17 ` Gerd Hoffmann [this message]
2022-03-02 11:29 ` [edk2-devel] " Boeuf, Sebastien
2022-03-01 13:29 ` [PATCH v5 5/7] OvmfPkg: CloudHv: Retrieve RSDP address from PVH Boeuf, Sebastien
2022-03-01 13:29 ` [PATCH v5 6/7] OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS Boeuf, Sebastien
2022-03-01 13:29 ` [PATCH v5 7/7] OvmfPkg: CloudHv: Add README Boeuf, Sebastien
2022-03-02 7:17 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302071713.4kooi46ox3o6mu7h@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox