From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.5998.1646218617982764819 for ; Wed, 02 Mar 2022 02:56:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WLPZpgeF; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646218616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QYC7wIcx2e0Yulm9k8ZUWjccvYcS+CglfNEjvbsS6XY=; b=WLPZpgeFlgMKIJYguM2cJOdatN9981R6WsivEAFgQL5a90MSIUYqyar159VnQ2BqWWR6Fq ybDLzmc+BUdOfUfSMMhX5nBEzgKanfwRtvESSbTPMT+ECKXH8mQ++NGakpDuK60+qqPf1n kB+LnG43ZmUt9QpXRWsHYsfxXp6Mmx4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-312-qarDgaK_P3yMLBlnkNeXSA-1; Wed, 02 Mar 2022 05:56:53 -0500 X-MC-Unique: qarDgaK_P3yMLBlnkNeXSA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C422801AFE; Wed, 2 Mar 2022 10:56:52 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.194.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FA287554D; Wed, 2 Mar 2022 10:56:52 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7FDC41800394; Wed, 2 Mar 2022 08:17:13 +0100 (CET) Date: Wed, 2 Mar 2022 08:17:13 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, sebastien.boeuf@intel.com Cc: jiewen.yao@intel.com, jordan.l.justen@intel.com Subject: Re: [edk2-devel] [PATCH v5 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary Message-ID: <20220302071713.4kooi46ox3o6mu7h@sirius.home.kraxel.org> References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > -[FD.CLOUDHV_VARS] > -[FD.CLOUDHV_CODE] Dropping these two should be a separate patch, so this patch becomes more readable. > -0x00000000|$(FVMAIN_SIZE) > +0x00001000|$(FVMAIN_SIZE) FVMAIN_SIZE is not changes anywhere it seems. So CLOUDHV.fd ends up with some odd size (instead of 2M or 4M) I guess? (not much of a problem though if cloudhv doesn't care ...) > diff --git a/OvmfPkg/VarStore.fdf.inc b/OvmfPkg/VarStore.fdf.inc > index a1e524e393..a1cbc74fbb 100644 > --- a/OvmfPkg/VarStore.fdf.inc > +++ b/OvmfPkg/VarStore.fdf.inc > @@ -15,6 +15,7 @@ > 0x00000000|0x00040000 > !endif > #NV_VARIABLE_STORE > + > DATA = { > ## This is the EFI_FIRMWARE_VOLUME_HEADER > # ZeroVector [] leftover whitespace update take care, Gerd