From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.5848.1646216817067968988 for ; Wed, 02 Mar 2022 02:26:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZjqWMUI9; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646216815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9tQvgLhgscHxtfDM0CCMrAXKR7gP4u3d1cuTQNlIO4k=; b=ZjqWMUI9/j4S4TgjLWPdy28dSXQtfwaMdOPbd/8wmanZo0S+phBNcjFbAcTG+wA68dNhNM PI+6K5eEw0Irtan24k9A1Is46v0GOfT22muUNG6tk023Wa0w+vhPTHGmTKAlDH0JZsMFdt 3mxuE7+WAWxQnvxK6w2TMniex7Yv48Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433--3lGTDixOo-DJoESQktiMg-1; Wed, 02 Mar 2022 05:26:54 -0500 X-MC-Unique: -3lGTDixOo-DJoESQktiMg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D03701091DA3; Wed, 2 Mar 2022 10:26:52 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.194.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8444B1042A97; Wed, 2 Mar 2022 10:26:52 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 92A7918003B3; Wed, 2 Mar 2022 08:58:33 +0100 (CET) Date: Wed, 2 Mar 2022 08:58:33 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, yi1.li@intel.com Cc: "Kovvuri, Vineel" , "Yao, Jiewen" , "Luo, Heng" Subject: Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms Message-ID: <20220302075833.bogcfpzv57t6cg7t@sirius.home.kraxel.org> References: <26433.1645811519240546455@groups.io> <20220301140451.wtqcyt6vyus5klgw@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > 2. Jiewen (Cc'ed) suggested to look into using CryptoPkg/Driver instead of linking openssl as Library, so we have only one copy of the code. Not investigated yet. > > Does it means OvmfPkg will use CryptDxe instead of BaseCryptoLib and OpensslLib directly? Sounds will be a big change. Havn't checked yet how much of a change that would be. Looks like CryptoPkg/Library/BaseCryptLibOnProtocolPpi is a drop-in replacement for CryptoPkg/Library/BaseCryptLib, which will call EDKII_CRYPTO_PROTOCOL provided by CryptoPkg/Driver instead of linking in the crypto bits from openssl. Apparently there isn't something simliar for OpensslLib though. > Or a separate ECC Driver such CryptEcDxe and still use BaseCryptoLib and OpensslLib? Would probably make sense to just add ecc support to the existing CryptoPkg/Driver. take care, Gerd