From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.6907.1646400932093587597 for ; Fri, 04 Mar 2022 05:35:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HaVSHan4; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646400931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kdKCqr+sBhGgCD808nCwCnF7De1tvY2EI+NM6WBrbyg=; b=HaVSHan4suDsrZiExYzV7cFYeKKI8XbLSkuca9fEQoGMy1ynohkJ0XBRnh/QZ7fKp5lZeG vXVPdS08L6l+KUTBbqzJw130aInWtuKljUndh9pnTDlxpTGcFY8y4Vcs8QEuM0agg8G5Fp v2n9vieac+IL3nNQaT5plTomsEhgsBw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-LSEgup6KNy6Ok_UDfPvPKw-1; Fri, 04 Mar 2022 08:35:30 -0500 X-MC-Unique: LSEgup6KNy6Ok_UDfPvPKw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 28BA9824FA7 for ; Fri, 4 Mar 2022 13:35:28 +0000 (UTC) Received: from osteffen-laptop.redhat.com (unknown [10.39.194.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 76EF27B5F1; Fri, 4 Mar 2022 13:35:27 +0000 (UTC) From: "Oliver Steffen" To: devel@edk2.groups.io Cc: Oliver Steffen Subject: [PATCH 4/4] NetworkPkg/HttpDxe: Detect non-HTTP/1.1 servers Date: Fri, 4 Mar 2022 14:34:31 +0100 Message-Id: <20220304133431.53378-5-osteffen@redhat.com> In-Reply-To: <20220304133431.53378-1-osteffen@redhat.com> References: <20220304133431.53378-1-osteffen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=osteffen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="US-ASCII" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2720 Force connecton close before the next request if the server does not identify as version 1.1. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpImpl.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/HttpDxe/HttpImpl.c index a1a3eea585..ea1ab60517 100644 --- a/NetworkPkg/HttpDxe/HttpImpl.c +++ b/NetworkPkg/HttpDxe/HttpImpl.c @@ -1105,6 +1105,14 @@ HttpResponseWorker ( HttpInstance->CacheLen =3D BodyLen;=0D }=0D =20=0D + //=0D + // Check server's HTTP version.=0D + //=0D + if (AsciiStrnCmp (HttpHeaders, HTTP_VERSION, AsciiStrLen (HTTP_VERSION= )) !=3D 0) {=0D + DEBUG ((DEBUG_WARN, "HTTP: Server version is not 1.1. Setting Connec= tion close.\n"));=0D + HttpInstance->ConnectionClose =3D TRUE;=0D + }=0D +=0D //=0D // Search for Status Code.=0D //=0D --=20 2.35.1