[PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

[PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

[Wu, Hao A]

Starting from ACPI Specification Version 5.1 Errata B, the term
'Correctable' is no longer being used as an error severity of the
reported error in Chapter 18 APEI.

This commit adds a new macro to reflect this and also keeps the origin
definition (but add comments to make it deprecated) for compatibility
consideration.

Please also note that this commit only updates Acpi64.h and
does NOT update below headers:
Acpi51.h
Acpi60.h
Acpi61.h
Acpi62.h
Acpi63.h

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
 MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
index a79b7f2eaa..232697f228 100644
--- a/MdePkg/Include/IndustryStandard/Acpi64.h
+++ b/MdePkg/Include/IndustryStandard/Acpi64.h
@@ -1,7 +1,7 @@
 /** @file
   ACPI 6.4 definitions from the ACPI Specification Revision 6.4 Jan, 2021.
 
-  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2017 - 2022, Intel Corporation. All rights reserved.<BR>
   Copyright (c) 2019 - 2021, ARM Ltd. All rights reserved.<BR>
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -1783,10 +1783,16 @@ typedef struct {
 //
 // Boot Error Severity types
 //
-#define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTABLE  0x00
+#define EFI_ACPI_6_4_ERROR_SEVERITY_RECOVERABLE  0x00
 #define EFI_ACPI_6_4_ERROR_SEVERITY_FATAL        0x01
 #define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTED    0x02
 #define EFI_ACPI_6_4_ERROR_SEVERITY_NONE         0x03
+//
+// The term 'Correctable' is no longer being used as an error severity of the
+// reported error since ACPI Specification Version 5.1 Errata B.
+// The below macro is considered as deprecated and should no longer be used.
+//
+#define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTABLE  0x00
 
 ///
 /// Generic Error Data Entry Definition
-- 
2.27.0.windows.1

回复: [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

[gaoliming]

Hao:
  Can you let me know why you update Acpi64.h only?

Thanks
Liming
> -----邮件原件-----
> 发件人: Hao A Wu <hao.a.wu@intel.com>
> 发送时间: 2022年3月7日 16:35
> 收件人: devel@edk2.groups.io
> 抄送: Hao A Wu <hao.a.wu@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error
> Status Block
> 
> Starting from ACPI Specification Version 5.1 Errata B, the term
> 'Correctable' is no longer being used as an error severity of the
> reported error in Chapter 18 APEI.
> 
> This commit adds a new macro to reflect this and also keeps the origin
> definition (but add comments to make it deprecated) for compatibility
> consideration.
> 
> Please also note that this commit only updates Acpi64.h and
> does NOT update below headers:
> Acpi51.h
> Acpi60.h
> Acpi61.h
> Acpi62.h
> Acpi63.h
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index a79b7f2eaa..232697f228 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -1,7 +1,7 @@
>  /** @file
> 
>    ACPI 6.4 definitions from the ACPI Specification Revision 6.4 Jan,
2021.
> 
> 
> 
> -  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> 
> +  Copyright (c) 2017 - 2022, Intel Corporation. All rights reserved.<BR>
> 
>    Copyright (c) 2019 - 2021, ARM Ltd. All rights reserved.<BR>
> 
> 
> 
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -1783,10 +1783,16 @@ typedef struct {
>  //
> 
>  // Boot Error Severity types
> 
>  //
> 
> -#define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTABLE  0x00
> 
> +#define EFI_ACPI_6_4_ERROR_SEVERITY_RECOVERABLE  0x00
> 
>  #define EFI_ACPI_6_4_ERROR_SEVERITY_FATAL        0x01
> 
>  #define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTED    0x02
> 
>  #define EFI_ACPI_6_4_ERROR_SEVERITY_NONE         0x03
> 
> +//
> 
> +// The term 'Correctable' is no longer being used as an error severity of
the
> 
> +// reported error since ACPI Specification Version 5.1 Errata B.
> 
> +// The below macro is considered as deprecated and should no longer be
> used.
> 
> +//
> 
> +#define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTABLE  0x00
> 
> 
> 
>  ///
> 
>  /// Generic Error Data Entry Definition
> 
> --
> 2.27.0.windows.1

Re: [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

[Wu, Hao A]

Hello Liming,

My take is that the consumers of the ACPI header file will always use the latest version.
Is my understanding correct? Or should I update all the header files relating to the affected versions (5.1~6.4) of the ACPI spec?

Best Regards,
Hao Wu

> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, March 8, 2022 9:42 AM
> To: Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>
> Subject: 回复: [PATCH] MdePkg/Acpi64: Update Error Severity type for
> Generic Error Status Block
> 
> Hao:
>   Can you let me know why you update Acpi64.h only?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Hao A Wu <hao.a.wu@intel.com>
> > 发送时间: 2022年3月7日 16:35
> > 收件人: devel@edk2.groups.io
> > 抄送: Hao A Wu <hao.a.wu@intel.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Zhiguang Liu <zhiguang.liu@intel.com>
> > 主题: [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic
> > Error Status Block
> >
> > Starting from ACPI Specification Version 5.1 Errata B, the term
> > 'Correctable' is no longer being used as an error severity of the
> > reported error in Chapter 18 APEI.
> >
> > This commit adds a new macro to reflect this and also keeps the origin
> > definition (but add comments to make it deprecated) for compatibility
> > consideration.
> >
> > Please also note that this commit only updates Acpi64.h and does NOT
> > update below headers:
> > Acpi51.h
> > Acpi60.h
> > Acpi61.h
> > Acpi62.h
> > Acpi63.h
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> > ---
> >  MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> > b/MdePkg/Include/IndustryStandard/Acpi64.h
> > index a79b7f2eaa..232697f228 100644
> > --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> > @@ -1,7 +1,7 @@
> >  /** @file
> >
> >    ACPI 6.4 definitions from the ACPI Specification Revision 6.4 Jan,
> 2021.
> >
> >
> >
> > -  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> >
> > +  Copyright (c) 2017 - 2022, Intel Corporation. All rights
> > + reserved.<BR>
> >
> >    Copyright (c) 2019 - 2021, ARM Ltd. All rights reserved.<BR>
> >
> >
> >
> >    SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -1783,10 +1783,16 @@ typedef struct {  //
> >
> >  // Boot Error Severity types
> >
> >  //
> >
> > -#define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTABLE  0x00
> >
> > +#define EFI_ACPI_6_4_ERROR_SEVERITY_RECOVERABLE  0x00
> >
> >  #define EFI_ACPI_6_4_ERROR_SEVERITY_FATAL        0x01
> >
> >  #define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTED    0x02
> >
> >  #define EFI_ACPI_6_4_ERROR_SEVERITY_NONE         0x03
> >
> > +//
> >
> > +// The term 'Correctable' is no longer being used as an error
> > +severity of
> the
> >
> > +// reported error since ACPI Specification Version 5.1 Errata B.
> >
> > +// The below macro is considered as deprecated and should no longer
> > +be
> > used.
> >
> > +//
> >
> > +#define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTABLE  0x00
> >
> >
> >
> >  ///
> >
> >  /// Generic Error Data Entry Definition
> >
> > --
> > 2.27.0.windows.1
> 
> 

Re: [edk2-devel] [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

[Ni, Ray]

The Acpixx.h are not like Pcixx.h. There are duplications among them (using different structure/macro prefix with version embedded).

I suggest we either update all of them, or we refactor the Acpixx.h to remove the duplications through "typedef" or "define".

The easier way for this small change can be just to update all duplicated code.

Thanks,
Ray

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao A
Sent: Tuesday, March 8, 2022 9:46 AM
To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

Hello Liming,

My take is that the consumers of the ACPI header file will always use the latest version.
Is my understanding correct? Or should I update all the header files relating to the affected versions (5.1~6.4) of the ACPI spec?

Best Regards,
Hao Wu

> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, March 8, 2022 9:42 AM
> To: Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang 
> <zhiguang.liu@intel.com>
> Subject: 回复: [PATCH] MdePkg/Acpi64: Update Error Severity type for 
> Generic Error Status Block
> 
> Hao:
>   Can you let me know why you update Acpi64.h only?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Hao A Wu <hao.a.wu@intel.com>
> > 发送时间: 2022年3月7日 16:35
> > 收件人: devel@edk2.groups.io
> > 抄送: Hao A Wu <hao.a.wu@intel.com>; Michael D Kinney 
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; 
> > Zhiguang Liu <zhiguang.liu@intel.com>
> > 主题: [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic 
> > Error Status Block
> >
> > Starting from ACPI Specification Version 5.1 Errata B, the term 
> > 'Correctable' is no longer being used as an error severity of the 
> > reported error in Chapter 18 APEI.
> >
> > This commit adds a new macro to reflect this and also keeps the 
> > origin definition (but add comments to make it deprecated) for 
> > compatibility consideration.
> >
> > Please also note that this commit only updates Acpi64.h and does NOT 
> > update below headers:
> > Acpi51.h
> > Acpi60.h
> > Acpi61.h
> > Acpi62.h
> > Acpi63.h
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> > ---
> >  MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> > b/MdePkg/Include/IndustryStandard/Acpi64.h
> > index a79b7f2eaa..232697f228 100644
> > --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> > @@ -1,7 +1,7 @@
> >  /** @file
> >
> >    ACPI 6.4 definitions from the ACPI Specification Revision 6.4 
> > Jan,
> 2021.
> >
> >
> >
> > -  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> >
> > +  Copyright (c) 2017 - 2022, Intel Corporation. All rights 
> > + reserved.<BR>
> >
> >    Copyright (c) 2019 - 2021, ARM Ltd. All rights reserved.<BR>
> >
> >
> >
> >    SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -1783,10 +1783,16 @@ typedef struct {  //
> >
> >  // Boot Error Severity types
> >
> >  //
> >
> > -#define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTABLE  0x00
> >
> > +#define EFI_ACPI_6_4_ERROR_SEVERITY_RECOVERABLE  0x00
> >
> >  #define EFI_ACPI_6_4_ERROR_SEVERITY_FATAL        0x01
> >
> >  #define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTED    0x02
> >
> >  #define EFI_ACPI_6_4_ERROR_SEVERITY_NONE         0x03
> >
> > +//
> >
> > +// The term 'Correctable' is no longer being used as an error 
> > +severity of
> the
> >
> > +// reported error since ACPI Specification Version 5.1 Errata B.
> >
> > +// The below macro is considered as deprecated and should no longer 
> > +be
> > used.
> >
> > +//
> >
> > +#define EFI_ACPI_6_4_ERROR_SEVERITY_CORRECTABLE  0x00
> >
> >
> >
> >  ///
> >
> >  /// Generic Error Data Entry Definition
> >
> > --
> > 2.27.0.windows.1
> 
>