From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web12.25336.1646653984360829862 for ; Mon, 07 Mar 2022 03:53:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RQFx7gbO; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646653983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bS8S/E3k3F54oSoU38mKlLvMlPu16gZBwWZVtEVZBFg=; b=RQFx7gbOtkvy1KxMobLS0nd+H4P53aJ9HifUQbnlBl06LiDqdmfEIWoTe4TsYGjV0nqclI wrDLNa6sGk51kpvnKl4ktWH/Ek2IoYW+wIX4iWQzKBl8OUx9Wkd4HQDOqsOxFGH9RKbV+f 79ecnKalNt2GzRXPoLqFFVqSz4/IFbQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201-LSp2v80nMoiap9NXteWAfQ-1; Mon, 07 Mar 2022 06:52:59 -0500 X-MC-Unique: LSp2v80nMoiap9NXteWAfQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C506E1006AA5 for ; Mon, 7 Mar 2022 11:52:58 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76B9E7555A; Mon, 7 Mar 2022 11:52:58 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 61FA41800612; Mon, 7 Mar 2022 12:52:56 +0100 (CET) Date: Mon, 7 Mar 2022 12:52:56 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, osteffen@redhat.com Subject: Re: [edk2-devel] [PATCH 1/4] NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring Message-ID: <20220307115256.bdgeocmex4pep6sc@sirius.home.kraxel.org> References: <20220304133431.53378-1-osteffen@redhat.com> <20220304133431.53378-2-osteffen@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220304133431.53378-2-osteffen@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 04, 2022 at 02:34:28PM +0100, Oliver Steffen wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 > > Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or > HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before > configuring it again. > > Signed-off-by: Oliver Steffen > --- > NetworkPkg/HttpDxe/HttpProto.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c > index 9457dd2623..cd54c57404 100644 > --- a/NetworkPkg/HttpDxe/HttpProto.c > +++ b/NetworkPkg/HttpDxe/HttpProto.c > @@ -1086,6 +1086,18 @@ HttpConfigureTcp4 ( > Tcp4Option->EnableNagle = TRUE; > > Tcp4CfgData->ControlOption = Tcp4Option; > > > > + if ((HttpInstance->State == HTTP_STATE_TCP_CONNECTED) || > > + (HttpInstance->State == HTTP_STATE_TCP_CLOSED)) Line breaks are mangled, probably due to edk2 using dos/windows style linebreaks. Running BaseTools/Scripts/SetupGit.py once should update the git configuration according. Otherwise the patch looks good to me. take care, Gerd