From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.25361.1646654151627329554
 for <devel@edk2.groups.io>;
 Mon, 07 Mar 2022 03:55:51 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZYMRaqe2;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1646654150;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uCzvR6JkIG7XeNJnEp7Y04ZYfJxNU4tFog7ag4Pwo5U=;
	b=ZYMRaqe20EOPHhPTyVYMNi9BoZD1wetAi5Q28C7fBvbKZ94MWgBYmnE2sWJNctLUdYrd4K
	1nFlLmnpc+10mkjiGwfdr/GxiTUKEG4eWFQXd6iOF7KqS5ML5w1tIusEyTWeO7WUrjVAew
	BGbCSGkMYEEeKvOzaP8chabVi3TTEvg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-656-45tDSVQRMRynPhDw7E64wA-1; Mon, 07 Mar 2022 06:55:49 -0500
X-MC-Unique: 45tDSVQRMRynPhDw7E64wA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 996081800D50
	for <devel@edk2.groups.io>; Mon,  7 Mar 2022 11:55:48 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.99])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id F202C8309D;
	Mon,  7 Mar 2022 11:55:46 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id E81CF1800612; Mon,  7 Mar 2022 12:55:44 +0100 (CET)
Date: Mon, 7 Mar 2022 12:55:44 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, osteffen@redhat.com
Subject: Re: [edk2-devel] [PATCH 2/4] NetworkPkg/HttpDxe: Add ConnectionClose flag fo HTTP_PROTOCOL
Message-ID: <20220307115544.gpdgba4hi4mhmmow@sirius.home.kraxel.org>
References: <20220304133431.53378-1-osteffen@redhat.com>
 <20220304133431.53378-3-osteffen@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20220304133431.53378-3-osteffen@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> -      if ((HttpInstance->RemotePort == RemotePort) &&
> 
> +      if ((HttpInstance->ConnectionClose == FALSE) &&
> 
> +          (HttpInstance->RemotePort == RemotePort) &&

Adding a check for the port makes sense, but that change should also be
mentioned in the commit message (or splitted into a separate patch, but
that's probably overkill for a one-liner).

take care,
  Gerd