From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, osteffen@redhat.com
Subject: Re: [edk2-devel] [PATCH 3/4] NetworkPkg/HttpDxe: Detect 'Connection: close' header
Date: Mon, 7 Mar 2022 12:59:22 +0100 [thread overview]
Message-ID: <20220307115922.3jnnx27sffilj24d@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220304133431.53378-4-osteffen@redhat.com>
On Fri, Mar 04, 2022 at 02:34:30PM +0100, Oliver Steffen wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
>
> Force connecton close before the next request if
> the server sends the 'Connection: close' header.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
> NetworkPkg/HttpDxe/HttpImpl.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/HttpDxe/HttpImpl.c
> index d8b014c94f..a1a3eea585 100644
> --- a/NetworkPkg/HttpDxe/HttpImpl.c
> +++ b/NetworkPkg/HttpDxe/HttpImpl.c
> @@ -994,6 +994,7 @@ HttpResponseWorker (
> UINTN HdrLen;
>
> NET_FRAGMENT Fragment;
>
> UINT32 TimeoutValue;
>
> + UINTN index;
Should be "Index" (edk2 codestyle).
> + if ((AsciiStriCmp ("Connection", HttpMsg->Headers[index].FieldName) == 0) &&
>
> + (AsciiStriCmp ("close", HttpMsg->Headers[index].FieldValue) == 0))
>
> + {
>
> + DEBUG ((DEBUG_WARN, "Http: 'Connection: close' header received.\n"));
I'd suggest to use DEBUG_VERBOSE here.
Otherwise the patch looks good to me.
take care,
Gerd
next prev parent reply other threads:[~2022-03-07 11:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 13:34 [PATCH 0/4] Http Fixes Oliver Steffen
2022-03-04 13:34 ` [PATCH 1/4] NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring Oliver Steffen
2022-03-07 11:52 ` [edk2-devel] " Gerd Hoffmann
2022-03-04 13:34 ` [PATCH 2/4] NetworkPkg/HttpDxe: Add ConnectionClose flag fo HTTP_PROTOCOL Oliver Steffen
2022-03-07 11:55 ` [edk2-devel] " Gerd Hoffmann
2022-03-04 13:34 ` [PATCH 3/4] NetworkPkg/HttpDxe: Detect 'Connection: close' header Oliver Steffen
2022-03-07 11:59 ` Gerd Hoffmann [this message]
2022-03-04 13:34 ` [PATCH 4/4] NetworkPkg/HttpDxe: Detect non-HTTP/1.1 servers Oliver Steffen
2022-03-07 12:07 ` [edk2-devel] " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307115922.3jnnx27sffilj24d@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox