* [PATCH EDK2 v1 0/1] UefiCpuPkg/MpInitLib:remove optional in declaration
@ 2022-03-10 8:06 wenyi,xie
2022-03-10 8:06 ` [PATCH EDK2 v1 1/1] " wenyi,xie
0 siblings, 1 reply; 3+ messages in thread
From: wenyi,xie @ 2022-03-10 8:06 UTC (permalink / raw)
To: devel, eric.dong, ray.ni, rahul1.kumar; +Cc: songdongkuang, xiewenyi2
Main Changes :
1.Remove suffix optional in declaration of WakeUpAP to keep declaration same with definition.
Wenyi Xie (1):
UefiCpuPkg/MpInitLib:remove optional in declaration
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH EDK2 v1 1/1] UefiCpuPkg/MpInitLib:remove optional in declaration
2022-03-10 8:06 [PATCH EDK2 v1 0/1] UefiCpuPkg/MpInitLib:remove optional in declaration wenyi,xie
@ 2022-03-10 8:06 ` wenyi,xie
2022-03-14 3:34 ` [edk2-devel] " Ni, Ray
0 siblings, 1 reply; 3+ messages in thread
From: wenyi,xie @ 2022-03-10 8:06 UTC (permalink / raw)
To: devel, eric.dong, ray.ni, rahul1.kumar; +Cc: songdongkuang, xiewenyi2
To keep the declaration same with definition, remove the last optional
in declaration of WakeUpAP.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 7d84a56fbc51..f8c52426dd5f 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -477,7 +477,7 @@ WakeUpAP (
IN UINTN ProcessorNumber,
IN EFI_AP_PROCEDURE Procedure OPTIONAL,
IN VOID *ProcedureArgument OPTIONAL,
- IN BOOLEAN WakeUpDisabledAps OPTIONAL
+ IN BOOLEAN WakeUpDisabledAps
);
/**
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH EDK2 v1 1/1] UefiCpuPkg/MpInitLib:remove optional in declaration
2022-03-10 8:06 ` [PATCH EDK2 v1 1/1] " wenyi,xie
@ 2022-03-14 3:34 ` Ni, Ray
0 siblings, 0 replies; 3+ messages in thread
From: Ni, Ray @ 2022-03-14 3:34 UTC (permalink / raw)
To: devel@edk2.groups.io, xiewenyi2@huawei.com, Dong, Eric,
Kumar, Rahul1
Cc: songdongkuang@huawei.com
Reviewed-by: Ray Ni <ray.ni@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of wenyi,xie via groups.io
Sent: Thursday, March 10, 2022 4:06 PM
To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
Subject: [edk2-devel] [PATCH EDK2 v1 1/1] UefiCpuPkg/MpInitLib:remove optional in declaration
To keep the declaration same with definition, remove the last optional in declaration of WakeUpAP.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 7d84a56fbc51..f8c52426dd5f 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -477,7 +477,7 @@ WakeUpAP (
IN UINTN ProcessorNumber,
IN EFI_AP_PROCEDURE Procedure OPTIONAL,
IN VOID *ProcedureArgument OPTIONAL,
- IN BOOLEAN WakeUpDisabledAps OPTIONAL
+ IN BOOLEAN WakeUpDisabledAps
);
/**
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-14 3:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-10 8:06 [PATCH EDK2 v1 0/1] UefiCpuPkg/MpInitLib:remove optional in declaration wenyi,xie
2022-03-10 8:06 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2022-03-14 3:34 ` [edk2-devel] " Ni, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox