From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.72]) by mx.groups.io with SMTP id smtpd.web12.12523.1646933978499702854 for ; Thu, 10 Mar 2022 09:39:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=EdHLColG; spf=pass (domain: arm.com, ip: 40.107.0.72, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vnXiTlQo/ZbQUd7k8cGRQTb5YOb7gGzbMpfd/6Dki1M=; b=EdHLColGs+J3yKV8UpbRC7GB3G17a4x1KuayTVjyC6DvPKeO6GrOOxL51xrBeMtT7B+XDNiWjJ8xmdTRdD8MlC8BLhh+dLk/MzapMvePC21RSg85yDvkdLxtqWc/ee7psUSfr11owJelC41SFwMGkAO2AuEWRfGBi7O6I6La2Is= Received: from AM6PR04CA0029.eurprd04.prod.outlook.com (2603:10a6:20b:92::42) by AM5PR0802MB2465.eurprd08.prod.outlook.com (2603:10a6:203:9f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Thu, 10 Mar 2022 17:39:35 +0000 Received: from VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:92:cafe::72) by AM6PR04CA0029.outlook.office365.com (2603:10a6:20b:92::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22 via Frontend Transport; Thu, 10 Mar 2022 17:39:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT061.mail.protection.outlook.com (10.152.19.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22 via Frontend Transport; Thu, 10 Mar 2022 17:39:34 +0000 Received: ("Tessian outbound 18e50a6f0513:v113"); Thu, 10 Mar 2022 17:39:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8afb5e43ae452961 X-CR-MTA-TID: 64aa7808 Received: from e53b03cff89c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4C07A3E9-ACD9-4768-9030-378D8121DE11.1; Thu, 10 Mar 2022 17:39:26 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e53b03cff89c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Mar 2022 17:39:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XJYL5aQptXDrpCXLB13UCiwljjLczeMOIKx3If8EY2b/llJbnTkpN2+lX0ndX3UsFC7/7YrO801Cjg/j1B3xQeeViPYfD6vNnvds6TrHfdxFrEoKHFcWiuek4Y4AisEljCqCJiYdymFUj/e41bJp/pumR1WKQ4ETsziRoiiu5rhOV860w3NJybII59i64zNZshn/i+c1VHmo3UcgwT5sdQBTFOq2RT91oOQ8/sPG12D5pb0fkftWzzicLVUA58ZZW2A5usqBlZELnUxk7PbTvUVL9qs/FdRDbNMvDZOZzDhkJX6MOOwaEvKCt9DxTFHlY6LFpSoRCiFAGl8kzcPd8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vnXiTlQo/ZbQUd7k8cGRQTb5YOb7gGzbMpfd/6Dki1M=; b=S/IEkFfijm6UZUyEicTz18VWXeIWgBckM244bvj/8br4LQ20evxhuSru1dlvscZhDhF8rlhM8N3bf4AEY6KTcrwGJcMtEfVEI5SDy/1E+XSv6xJFWdl9h49wrClYll25+XIJBfcA/Xa90LcXGHVkFqdaqK3mej2PVHyArfgB5KaRDkWyE6ksjGuibgCHb3DTIsUgIgxI9Nj0r+hDGHa8fr9+N67+6bg43WD/By0dCP4gF+Vepf9AyF1MHfGF4ceux7OghzyGZpbQ/CWCHRu44SGRXSyq94Jk8m+fSmdEdiXvqzr3It5OlwI1RpRKMuEXLrGfP3ebs4M5WFMqN1WQfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vnXiTlQo/ZbQUd7k8cGRQTb5YOb7gGzbMpfd/6Dki1M=; b=EdHLColGs+J3yKV8UpbRC7GB3G17a4x1KuayTVjyC6DvPKeO6GrOOxL51xrBeMtT7B+XDNiWjJ8xmdTRdD8MlC8BLhh+dLk/MzapMvePC21RSg85yDvkdLxtqWc/ee7psUSfr11owJelC41SFwMGkAO2AuEWRfGBi7O6I6La2Is= Received: from AM6PR01CA0071.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::48) by PAXPR08MB6479.eurprd08.prod.outlook.com (2603:10a6:102:157::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.16; Thu, 10 Mar 2022 17:39:25 +0000 Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::53) by AM6PR01CA0071.outlook.office365.com (2603:10a6:20b:e0::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.29 via Frontend Transport; Thu, 10 Mar 2022 17:39:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5061.22 via Frontend Transport; Thu, 10 Mar 2022 17:39:24 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Mar 2022 17:39:28 +0000 Received: from E114225.Arm.com (10.1.196.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Thu, 10 Mar 2022 17:39:28 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2 Date: Thu, 10 Mar 2022 17:39:27 +0000 Message-ID: <20220310173927.105596-1-sami.mujawar@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: e6637cf9-def0-469f-cb30-08da02bcf10b X-MS-TrafficTypeDiagnostic: PAXPR08MB6479:EE_|VE1EUR03FT061:EE_|AM5PR0802MB2465:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dSGC62kzvgvBENyRxzI31FYe6FhyyKI6W4TeQcEkXVhXiZdox7Gs+zI/VC5Zj/yeuR5wduZJI/HVXoIHtCJOgBHTeYFhjJuPFbq5+oXnYLdpxepvC4rg7OlqVouhbKb3I6+ujQqZpZwmDLXbTUc2FhglBJgWt+waFwtqeN/mFsLHrV/X+LK52ccTxuKf9/0c1eaSVPnsZvSsRZPP7OKqtquL0y6i2t0IlDUPuO6rZtZw7G0dSZpuUHLrDspxGVweq5OwzEgxkkAYGkCcRvqbsfbI+dPGJPRSS3ROoyXpLlsKn/8JlNwgCT4dcRWyuVoMlD1T+2m7RCDUkKVtgWNK4MRTSz/NKCCf99hi/X+vMAeN8eReDRwWPfQY9i8AQ9LQL73dWgtdvhMs4Y7DjQkVymYINZRtQtya3GaAI/t9qC9rsNrS88+PC4eM/72GEBDTA+DZCh5N0gAP0Ag+NMqZ2ppi9+lDmbvf/CKa/b2LhkXkOi6WciHeqmSiU+okDdiFhCZhrcU2bbKf2tHwDTu6X9MUhjjwfT5GvZ7woyBWfwmrR9ERz2UYpT3OoUDKvTVaPu3DSG/aD8jlgqrn1zthS+jRC0G1w7TzVbQL1CQlgrlk9TZx+QxJ5EDApbYIBnpGXyiUBU3PLXgA0JY+xx12OF9D/T4+fQQfmO2E8p1/S41LjTgk1xJJBSdW3p8diP1bier3mYnLczHIFvDi4nQvR1ldMyUOsCoETeX0wi0/byznn0Z11FYx5BNlLCZzL7zDLUvtcwlAVX6aLlzhGVhPLuRsT/dOmxUZcbt8/kq2U+o= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(4326008)(8676002)(54906003)(40460700003)(2906002)(36756003)(5660300002)(81166007)(8936002)(6916009)(44832011)(966005)(508600001)(1076003)(2616005)(7696005)(336012)(186003)(26005)(426003)(82310400004)(356005)(83380400001)(36860700001)(47076005)(70586007)(70206006)(86362001)(316002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6479 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0eeb89c9-d811-4750-ab5c-08da02bceb09 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GUE2S5wv6K+LT/S1syif6LuJCd+77KY/qj/Iq9tEbuqOw3jqXeWLySR4hJ4peNv2Cl7AIn6cNLbat7ARN+YrLk6Gm9aCcc/pcfT6qxpFzKqr8xuLjyFe2LdxCGYo0VZ1KoAOHUO7PotTGbP3BXYMtJUmIhRl8gsbNSiZeKVzQ5VGV0PtjYaSLhAhE0Ba+x3crKB9h5og4GNDfvCZpGo5VsGJz1bgugU8HULuvDsE6AMnr7AR1LR08+YN5LzESYROTWwsIEbvDJAN41V1PKYw5SsIvRS1etQE42d/u8Ja/cy5cGrbP8AIdXN+kD2Uxv6UPYM/5te07uiOFsMYXDYRI4nxBZTlv84delxcPUcaEmHvzt8nQZbOnAOfURxS24qi8xtdzX6YAXLl+chH6DYO48JrHccDbFNSKGeJpxqM3l8oUY8D/GAvZ+rk5O0O/ameVMbfKtdeCWeSIQYaZo8De/Ob8Wv5jmaij0wKKM9oe8LfsF1G7iakIxriKbP0rytYS+wETXNPVRgbkrE0HVROUH0sGItA6MGZcsm/oYQ+wzerd/jRUc5/SJlb6Mq7uQyPxxmg3VZoXuvJVTi64ACPA1R7nAPkhciz+1WK9bVS/zoXo44+vLJY1XDdOymXwGwzmbibAN92Bqb9O25KYPro8bmjr0Pr8Lb+mv0BOe7/b8G1P1X+lJNSR8liA+qppdNXpe2r57Ry7N3g8wf8VmLYEEUZUCd1PWWG5IZTKQHTFA9EZv9d+KTrBEmcIHDXuLIzUCdPAwsDInxl5YIR5fxt4w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(40460700003)(70206006)(70586007)(1076003)(82310400004)(5660300002)(2616005)(44832011)(316002)(36860700001)(47076005)(4326008)(8676002)(36756003)(8936002)(86362001)(81166007)(83380400001)(6916009)(426003)(186003)(336012)(26005)(7696005)(2906002)(508600001)(966005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 17:39:34.6441 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6637cf9-def0-469f-cb30-08da02bcf10b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2465 Content-Type: text/plain According to the Debug Port Table 2 (DBG2) specification, February 17, 2021, the NamespaceString is a NULL terminated ASCII string that consists of a fully qualified reference to the object that represents the serial port device in the ACPI namespace. The DBG2 table generator did not populate the full device path for the serial port device, and this results in a FWTS test failure. Therefore, populate the full namespace device path for the serial port in DBG2 table. Signed-off-by: Sami Mujawar --- The changes can be seen at: https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1 DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c index 3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c @@ -1,7 +1,7 @@ /** @file DBG2 Table Generator - Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
+ Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -55,13 +55,17 @@ Requirements: */ #define NAME_STR_DBG_PORT0 "COM0" +/** A string representing the full path name of the debug port 0. +*/ +#define NAMESPACE_STR_DBG_PORT0 "\\_SB_.COM0" + /** An UID representing the debug port 0. */ #define UID_DBG_PORT0 0 /** The length of the namespace string. */ -#define DBG2_NAMESPACESTRING_FIELD_SIZE sizeof (NAME_STR_DBG_PORT0) +#define DBG2_NAMESPACESTRING_FIELD_SIZE sizeof (NAMESPACE_STR_DBG_PORT0) /** The PL011 UART address range length. */ @@ -166,7 +170,7 @@ DBG2_TABLE AcpiDbg2 = { 0, // {Template}: Serial Port Subtype 0, // {Template}: Serial Port Base Address PL011_UART_LENGTH, - NAME_STR_DBG_PORT0 + NAMESPACE_STR_DBG_PORT0 ) } }; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'