From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.8085.1647330106332039466 for ; Tue, 15 Mar 2022 00:41:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=N8zTBdN4; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647330104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7B/RwqPnt/pTCoeGQKt51rswk6kTjpJIQW4vjYEyA3c=; b=N8zTBdN4HEwldQmyKeuRhILPgqHP4j58y8z2VWzP4SPSIqLtY8aP/6xftAEDIEsPZWq35d mLzNa7tS4o4lUcLnDM6JOaEzJm6daXnm1GuAhkOxNXfrbv0x4j/WmWuu/QoCOcDBM7PPEA BgzA8czqrAHMl3NW5K3ue/zGYawL+d8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-QWuLI4zRPtCKGdQk1cFM8A-1; Tue, 15 Mar 2022 03:41:38 -0400 X-MC-Unique: QWuLI4zRPtCKGdQk1cFM8A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 124763803501; Tue, 15 Mar 2022 07:41:38 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.196.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4F874B8D4D; Tue, 15 Mar 2022 07:41:37 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7CED918003A2; Tue, 15 Mar 2022 08:41:34 +0100 (CET) Date: Tue, 15 Mar 2022 08:41:34 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Subject: Re: [PATCH V8 16/47] OvmfPkg: Create initial version of PlatformInitLib Message-ID: <20220315074134.hh2ewbkgwqvn2wiq@sirius.home.kraxel.org> References: <48bf7dfd512db3ec9e433490374354f01e48f432.1647047482.git.min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <48bf7dfd512db3ec9e433490374354f01e48f432.1647047482.git.min.m.xu@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Mar 12, 2022 at 09:53:41AM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 > > There are 3 variants of PlatformPei in OvmfPkg: > - OvmfPkg/PlatformPei > - OvmfPkg/XenPlatformPei > - OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf > These PlatformPeis can share many common codes, such as > Cmos / Hob / Memory / Platform related functions. This commit > (and its following several patches) are to create a PlatformInitLib > which wraps the common code called in above PlatformPeis. > > In this initial version of PlatformInitLib, below Cmos related functions > are introduced: > - PlatformCmosRead8 > - PlatformCmosWrite8 > - PlatformDebugDumpCmos > > They correspond to the functions in OvmfPkg/PlatformPei: > - CmosRead8 > - CmosWrite8 > - DebugDumpCmos > > Considering this PlatformInitLib will be used in SEC phase, global > variables and dynamic PCDs are avoided. We use PlatformInfoHob > to exchange information between functions. > > EFI_HOB_PLATFORM_INFO is the data struct which contains the platform > information, such as HostBridgeDevId, BootMode, S3Supported, > SmmSmramRequire, etc. > > After PlatformInitLib is created, OvmfPkg/PlatformPei is refactored > with this library. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Gerd Hoffmann > Signed-off-by: Min Xu Acked-by: Gerd Hoffmann