From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.8186.1647331056262222047
 for <devel@edk2.groups.io>;
 Tue, 15 Mar 2022 00:57:37 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bYQ+BmXa;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1647331055;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Q8WJvTVQEQLddQhZUSVGp4/t4MTMYqFOIsfgZDMmMx4=;
	b=bYQ+BmXayCab2xzTXbCiXGKhIvTinbFaYxmKPJWkrHFfYNo9F26pXhn9QWC++8eFNRvTrp
	2Sm9lg9xlEfBOyU18+oexqkCHN7vS3UBFEbQOtu2a4fd1cdNqqA7YAfIV3CjEHmvGL3bJD
	LpawhizY4UaBRKlSj7EIcBqLGgM0fqQ=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-595-eQYBD5ovMNGhG3q6dVTRfA-1; Tue, 15 Mar 2022 03:57:31 -0400
X-MC-Unique: eQYBD5ovMNGhG3q6dVTRfA-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C72641C05AD3;
	Tue, 15 Mar 2022 07:57:30 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.196.67])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 94CB0140241F;
	Tue, 15 Mar 2022 07:57:30 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 2C1DE18003A2; Tue, 15 Mar 2022 08:57:29 +0100 (CET)
Date: Tue, 15 Mar 2022 08:57:29 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>
Subject: Re: [PATCH V8 18/47] OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob
Message-ID: <20220315075729.nk57thjidnjbithg@sirius.home.kraxel.org>
References: <cover.1647047481.git.min.m.xu@intel.com>
 <e67bc4cdf1a24d81a0aad2acabb3131ca62d8d75.1647047482.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <e67bc4cdf1a24d81a0aad2acabb3131ca62d8d75.1647047482.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c
> index fb7e21ec140f..c180383b42b0 100644
> --- a/OvmfPkg/PlatformPei/AmdSev.c
> +++ b/OvmfPkg/PlatformPei/AmdSev.c
> @@ -24,6 +24,8 @@
>  
>  #include "Platform.h"
>  
> +extern EFI_HOB_PLATFORM_INFO  mPlatformInfoHob;

Move that line to Platform.h?

Otherwise looks good.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>