From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web08.8236.1647331168418996531
 for <devel@edk2.groups.io>;
 Tue, 15 Mar 2022 00:59:29 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GO9YH+6w;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1647331167;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tRlINyzQkjcM4+IZI7+5iC7zBUoZr1jzOD9YEvH5sCs=;
	b=GO9YH+6wdJzAVUP33cK2rgQLbHds2NxuL4ADk17WYzENAtCiyV+A0tjimDauHOzKETPHkN
	gBeK1b9mUrTBTL2TyKXBVSXRYk3VRHytvr9o5X5rwMjqE+SP8HZwCa6lCfDInHsVII5EeV
	OqE7EZv0kRK6/FLMudStcUIxpClUIa8=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-602-dy8FzVr4MqStaC-PekCX9Q-1; Tue, 15 Mar 2022 03:59:21 -0400
X-MC-Unique: dy8FzVr4MqStaC-PekCX9Q-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0BEFC1066559;
	Tue, 15 Mar 2022 07:59:21 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.196.67])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id CD7D0141ADA5;
	Tue, 15 Mar 2022 07:59:20 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 56AAF18003A2; Tue, 15 Mar 2022 08:59:19 +0100 (CET)
Date: Tue, 15 Mar 2022 08:59:19 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>
Subject: Re: [PATCH V8 19/47] OvmfPkg/PlatformPei: Refactor MiscInitialization
Message-ID: <20220315075919.6uja6un4y46372hy@sirius.home.kraxel.org>
References: <cover.1647047481.git.min.m.xu@intel.com>
 <14e29536cd50ddfd9443bcfd70da5c0438ac704f.1647047482.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <14e29536cd50ddfd9443bcfd70da5c0438ac704f.1647047482.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Mar 12, 2022 at 09:53:44AM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
> 
> In MiscInitialization Microvm looks a little weird. Other platforms
> call PcdSet16S to set the PcdOvmfHostBridgePciDevId with the value same
> as PlatformInfoHob->HostBridgeDevId. But Microvm doesn't follow this
> way. In switch-case 0xffff is Microvm, but set with
> MICROVM_PSEUDO_DEVICE_ID. So we have to add a new function
> ( MiscInitializationForMicrovm ) for Microvm and delete the code in
> MiscInitialization.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>