From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.10183.1647346987091721614 for ; Tue, 15 Mar 2022 05:23:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aH12dWFz; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647346986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ag+OG2maYC9Y3UY3X/OrkS/nDabtVujawYywKa0ZM8c=; b=aH12dWFz5nHqN91/mgQp7jf1p17MtEwlFOnyHE+fg9RMqmuzbhG6zm7jINOd6v5EDql3z1 KMEwS9Ai0pOIjhAfVPudyANuwJfqJoKZIJSqqIbTnDXem9aWXdgsUfEunTm7YcOD7qOvbe 4ShfZ+GU7AJnmLWStNxj3yXB/OpKqR4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-411-ujj56ohjOkqczeCdqmI-GA-1; Tue, 15 Mar 2022 08:22:51 -0400 X-MC-Unique: ujj56ohjOkqczeCdqmI-GA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A0A8C8038E3; Tue, 15 Mar 2022 12:22:49 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.196.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A891CC531E0; Tue, 15 Mar 2022 12:22:48 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 5871718003A2; Tue, 15 Mar 2022 13:22:42 +0100 (CET) Date: Tue, 15 Mar 2022 13:22:42 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Xiaoyu Lu , Bob Feng , Rebecca Cran , James Bottomley , Sami Mujawar , Jordan Justen , Erdem Aktas , Jiewen Yao , Supreeth Venkatesh , Sebastien Boeuf , Zhichao Gao , Zhiguang Liu , Maciej Rabeda , Maurice Ma , Andrew Fish , Ard Biesheuvel , Tom Lendacky , Peter Grehan , Sean Brogan , Guomin Jiang , Bret Barkelew , Yuwei Chen , Benjamin You , Daniel Schaefer , Liming Gao , Michael D Kinney , Wei6 Xu , Jian J Wang , Jiaxin Wu , Siyuan Fu , Guo Dong , kilian_kegel@hotmail.com, Abner Chang , Oliver Steffen , Leif Lindholm , Brijesh Singh , Min Xu , Ray Ni , Alexei Fedorov , Julien Grall , Nickle Wang , Pawel Polawski , Anthony Perard Subject: Re: [PATCH 0/3] [RFC] consolidate compiler intrinsics Message-ID: <20220315122242.xwi2xckfos2c3cff@sirius.home.kraxel.org> References: <20220301071820.3135133-1-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220301071820.3135133-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 01, 2022 at 08:18:17AM +0100, Gerd Hoffmann wrote: > This is an attept to start cleaning up the messy compiler intrinsics > situation. Today we don't have a core intrinsics library, resulting > in everybody creating their own. ArmPkg has one, CryptoPkg has one. > I'm sure there are many more. > > This doesn't make sense. Given we can't avoid compiler intrinsics (as > proven by the existence of those libraries) we should better have them > as core library so we have to maintain a single version only. > > Given we already have BaseIoLibIntrinsic in MdePkg we can place the > compiler intrinsics there too. This little patch series does just that: > It moves over the existing ArmPkg intrinsics, fixes them to build on > non-arm too, and adds additional bits from the CryptoPkg intrinsics. Ping. How go forward with this? I've posted it as RFC because I expected a more controversial discussion. But seems everybody agrees this is a step into the right direction. So just merge this as-is? Yes, it passed CI (https://github.com/tianocore/edk2/pull/2542). take care, Gerd