From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web08.11067.1647352013764524584 for ; Tue, 15 Mar 2022 06:46:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VhoiaN3m; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647352012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NUs5jSEOxtG8kYWvCY41Qpo3ei9nffu3hYf6W+9xbco=; b=VhoiaN3mTUvb/Ygwc1SzAIL9F7n5O3XJHy1bf+hWCjJ95PadDa8NJbK8uwckTbd81y3D5b k/kg36qoTDacGL6/oCCw2iuqH/u4cDqRqyVS78ke5dP+6glLz6tQ/WC5CrinSty44PTHa7 eO8UWk5Kd8Euj5OGU5K+++2pw0PiIzk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-395-lA5nVYcgN4uHvzsoKT3VEQ-1; Tue, 15 Mar 2022 09:46:49 -0400 X-MC-Unique: lA5nVYcgN4uHvzsoKT3VEQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BECA08001EA; Tue, 15 Mar 2022 13:46:48 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.196.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91C0AC33264; Tue, 15 Mar 2022 13:46:48 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4384D18003A2; Tue, 15 Mar 2022 14:46:47 +0100 (CET) Date: Tue, 15 Mar 2022 14:46:47 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Michael D Kinney , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Subject: Re: [PATCH V5 06/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob Message-ID: <20220315134647.za5cinazn2tctjid@sirius.home.kraxel.org> References: <20220313004111.388-1-min.m.xu@intel.com> <20220313004111.388-7-min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <20220313004111.388-7-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Mar 13, 2022 at 08:41:07AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > The entrypoint of DxeAcpiTimerLib checks HostBridgeDevId by reading > PcdOvmfHostBridgePciDevId. If the DevId is not set, ASSERT is > triggered. Normally this DevId is set in PlatformPei which is executed > in PEI phase. > > This patch-set is introducing PEI-less boot which means PEI phase is > skipped. So there is no chance to set this DevId. Instead HostBridgeDevId > is set in PlatformInfoHob. So we can check if PlatformInfoHob exists and > if HostBridgeDevId is set in this Hob. Acked-by: Gerd Hoffmann take care, Gerd