From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web12.10901.1647352169010565902
 for <devel@edk2.groups.io>;
 Tue, 15 Mar 2022 06:49:29 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KmAOjRZz;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1647352168;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=dFzwDfaTFJHqWPfWcS/4HZF9b+BANoRvF9kc3uG3A2w=;
	b=KmAOjRZzmGNvTetKdhtzJlTNP6AbsGV/uuZc8q5jh6drrxhxijo1v1QPTINf/PVQwGeZ5v
	DlpFQy1f/hSVAprJ/qNOE4irwDes9AsHg164kVRHp+3ZW3nWIk7lcYNnjwsje4XWRnBDuI
	kpIWuMI9pM+AyMHuGH7ndtkF5m0/XSY=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-513-WF96_p9zNCKlVBCRquE14w-1; Tue, 15 Mar 2022 09:49:22 -0400
X-MC-Unique: WF96_p9zNCKlVBCRquE14w-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ECF298002BF;
	Tue, 15 Mar 2022 13:49:21 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.196.67])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F9BB407F761;
	Tue, 15 Mar 2022 13:49:21 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id D56A018003A2; Tue, 15 Mar 2022 14:49:19 +0100 (CET)
Date: Tue, 15 Mar 2022 14:49:19 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Jian J Wang <jian.j.wang@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Hao A Wu <hao.a.wu@intel.com>, Ray Ni <ray.ni@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V5 09/10] MdeModulePkg: Update PciEnumeratorSupport to ignore OptionRom if needed
Message-ID: <20220315134919.wwblmnxx2bgkd6s2@sirius.home.kraxel.org>
References: <20220313004111.388-1-min.m.xu@intel.com>
 <20220313004111.388-10-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20220313004111.388-10-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Mar 13, 2022 at 08:41:10AM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> 
> Function of UpdatePciInfo() in PciEnumeratorSupport.c is used to update
> the bar information for those incompatible PCI device. It is the right
> place to check if the OptionRom need to be ignored.
> 
> According to "Table 20. ACPI 2.0 & 3.0 QWORD Address Space Descriptor
> Usage" in PI Spec 1.7, Type-specific flags can be set to 0 when Address
> Translation Offset == 6 to skip device option ROM (do not probe option
> rom BAR).
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>