From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Sean Brogan <sean.brogan@microsoft.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
Rebecca Cran <rebecca@bsdio.com>,
James Bottomley <jejb@linux.ibm.com>,
Sami Mujawar <Sami.Mujawar@arm.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
"Boeuf, Sebastien" <sebastien.boeuf@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
Maciej Rabeda <maciej.rabeda@linux.intel.com>,
"Ma, Maurice" <maurice.ma@intel.com>,
Andrew Fish <afish@apple.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Peter Grehan <grehan@freebsd.org>,
"Jiang, Guomin" <guomin.jiang@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Chen, Christine" <yuwei.chen@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>,
"Schaefer, Daniel" <daniel.schaefer@hpe.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Xu, Wei6" <wei6.xu@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"Dong, Guo" <guo.dong@intel.com>,
"kilian_kegel@hotmail.com" <kilian_kegel@hotmail.com>,
"Chang, Abner" <abner.chang@hpe.com>,
Oliver Steffen <osteffen@redhat.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Brijesh Singh <brijesh.singh@amd.com>,
"Xu, Min M" <min.m.xu@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
Julien Grall <julien@xen.org>,
"Wang, Nickle" <nickle.wang@hpe.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics
Date: Wed, 16 Mar 2022 10:45:38 +0100 [thread overview]
Message-ID: <20220316094538.t4ox4p5amfgwt5t6@sirius.home.kraxel.org> (raw)
In-Reply-To: <CO1PR11MB4929AC5EF9410BED2D88BB6CD2109@CO1PR11MB4929.namprd11.prod.outlook.com>
On Tue, Mar 15, 2022 at 03:27:58PM +0000, Michael D Kinney wrote:
> Hi Gerd,
>
> Thanks for working on this. I raised this topic in the new TianoCore build and CI
> meeting yesterday because the intrinsic libs are closely tied to the toolchains
> supported by TianoCore.
>
> I agree with the concept of moving the compiler intrinsics to a library in the MdePkg.
>
> + Sean Brogan
>
> Sean mentioned that he has some addition work on intrinsic libs for Visual Studio
> toolchains. It would be good to see if this set of changes is aligned with those
> efforts.
Having a single place where all compiler intrinsics are located should
simplify this kind of changes.
> I see a few items that might be good to clean up at some point
> * fltused should go into its own file. Not related to the strcmp() API
> * I see size_t defined in multiple places using different mappings. Would be good to
> define that in a single location.
Yes, sure. Both are valid points.
I see this series as first step, consolidating the existing code in a
singe place with (almost) no actual code changes. There surely will be
incremental improvements and cleanups later on. I will need a few more
intrinsic functions when moving edk2 to openssl 3.0 for example.
take care,
Gerd
next prev parent reply other threads:[~2022-03-16 9:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 7:18 [PATCH 0/3] [RFC] consolidate compiler intrinsics Gerd Hoffmann
2022-03-01 7:18 ` [PATCH 1/3] MdePkg: promote CompilerIntrinsicsLib from ArmPkg to MdePkg Gerd Hoffmann
2022-03-01 7:18 ` [PATCH 2/3] MdePkg/CompilerIntrinsicsLib: fix msft sources for x64 Gerd Hoffmann
2022-03-01 7:18 ` [PATCH 3/3] MdePkg/CompilerIntrinsicsLib: move ia32 intrinsics and strcmp Gerd Hoffmann
2022-03-02 2:06 ` 回复: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics gaoliming
2022-03-02 2:16 ` Yao, Jiewen
2022-03-02 8:39 ` Kilian Kegel
2022-03-02 10:10 ` Gerd Hoffmann
2022-03-02 6:12 ` Ard Biesheuvel
2022-03-15 12:22 ` Gerd Hoffmann
2022-03-15 15:27 ` Michael D Kinney
2022-03-16 9:45 ` Gerd Hoffmann [this message]
2022-03-18 1:26 ` 回复: [edk2-devel] " gaoliming
2022-03-18 1:54 ` Pedro Falcato
2022-03-15 17:08 ` Pedro Falcato
2022-03-16 10:02 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316094538.t4ox4p5amfgwt5t6@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox