From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.22993.1647423947353967023 for ; Wed, 16 Mar 2022 02:45:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Q4WFHDVV; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647423946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N0oDaeLVx6XJswdGKD8R/d/cMJ//EKfl2Zblaq4o70g=; b=Q4WFHDVVumjPsOQbhZ2L0Pc7flEgD5vMpSRbd1679UeA677z+ecrYjF/gX8lX9GFi/4/1T pVajA7MOL7cQoD3HZcmxdF/EEkDDiRHNq9PhkKnSf1jwdurGPY8hhq527K2aWAXU63otJp azN/XUxJ9GS3dZGCXbQoVgtXSmJ7Tq8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-448-FmZHLH2TODSbEJB-4helOw-1; Wed, 16 Mar 2022 05:45:42 -0400 X-MC-Unique: FmZHLH2TODSbEJB-4helOw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B1DD811E75; Wed, 16 Mar 2022 09:45:40 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.196.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1F1340F9D53; Wed, 16 Mar 2022 09:45:39 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8435A1800381; Wed, 16 Mar 2022 10:45:38 +0100 (CET) Date: Wed, 16 Mar 2022 10:45:38 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , "Lu, Xiaoyu1" , "Feng, Bob C" , Rebecca Cran , James Bottomley , Sami Mujawar , "Justen, Jordan L" , "Aktas, Erdem" , "Yao, Jiewen" , Supreeth Venkatesh , "Boeuf, Sebastien" , "Gao, Zhichao" , "Liu, Zhiguang" , Maciej Rabeda , "Ma, Maurice" , Andrew Fish , Ard Biesheuvel , Tom Lendacky , Peter Grehan , "Jiang, Guomin" , Bret Barkelew , "Chen, Christine" , "You, Benjamin" , "Schaefer, Daniel" , "Gao, Liming" , "Xu, Wei6" , "Wang, Jian J" , "Wu, Jiaxin" , "Fu, Siyuan" , "Dong, Guo" , "kilian_kegel@hotmail.com" , "Chang, Abner" , Oliver Steffen , Leif Lindholm , Brijesh Singh , "Xu, Min M" , "Ni, Ray" , Alexei Fedorov , Julien Grall , "Wang, Nickle" , Pawel Polawski , Anthony Perard Subject: Re: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics Message-ID: <20220316094538.t4ox4p5amfgwt5t6@sirius.home.kraxel.org> References: <20220301071820.3135133-1-kraxel@redhat.com> <20220315122242.xwi2xckfos2c3cff@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 15, 2022 at 03:27:58PM +0000, Michael D Kinney wrote: > Hi Gerd, > > Thanks for working on this. I raised this topic in the new TianoCore build and CI > meeting yesterday because the intrinsic libs are closely tied to the toolchains > supported by TianoCore. > > I agree with the concept of moving the compiler intrinsics to a library in the MdePkg. > > + Sean Brogan > > Sean mentioned that he has some addition work on intrinsic libs for Visual Studio > toolchains. It would be good to see if this set of changes is aligned with those > efforts. Having a single place where all compiler intrinsics are located should simplify this kind of changes. > I see a few items that might be good to clean up at some point > * fltused should go into its own file. Not related to the strcmp() API > * I see size_t defined in multiple places using different mappings. Would be good to > define that in a single location. Yes, sure. Both are valid points. I see this series as first step, consolidating the existing code in a singe place with (almost) no actual code changes. There surely will be incremental improvements and cleanups later on. I will need a few more intrinsic functions when moving edk2 to openssl 3.0 for example. take care, Gerd